From: "Michael Walle" <mwalle@kernel.org>
To: "Witold Sadowski" <wsadowski@marvell.com>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<broonie@kernel.org>
Cc: <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g
Date: Tue, 02 Apr 2024 10:34:52 +0200 [thread overview]
Message-ID: <D09HZ0PN0QB9.2TJR29LQ2F570@kernel.org> (raw)
In-Reply-To: <20240328115225.1783-1-wsadowski@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
[+ linux-mtd ]
Hi,
On Thu Mar 28, 2024 at 12:52 PM CET, Witold Sadowski wrote:
> The Macronix mx25um51245g is a 1.8V, 512Mbit (64MB) device that
> supports x1, or x8 operation.
>
> Tested on Marvell Octeon SoC hardware with a Cadence xSPI controller.
>
> Signed-off-by: Witold Sadowski <wsadowski@marvell.com>
You haven't CC'ed the correct list, therefore it's unlikely this
will get a proper review/getting merged at all.
As Krzysztof already pointed out on another series of yours, please
read submitting-patches.rst.
For nor flash related submissions please also read:
https://docs.kernel.org/driver-api/mtd/spi-nor.html
> ---
> drivers/mtd/spi-nor/macronix.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index ea6be95e75a5..f5fbdb7912e0 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -182,6 +182,12 @@ static const struct flash_info macronix_nor_parts[] = {
> .name = "mx25l3255e",
> .size = SZ_4M,
> .no_sfdp_flags = SECT_4K,
> + }, {
> + .id = SNOR_ID(0xc2, 0x80, 0x3a),
Wrong indentation?. Please use checkpatch.pl.
> + .name = "mx25um51245g",
drop the name.
> + .size = SZ_64M,
This is also autodetected. Drop it.
> + .no_sfdp_flags = SECT_4K,
No "no_sfdp_flags" for SFDP capable flashes. Drop it.
> + .fixup_flags = SPI_NOR_4B_OPCODES,
Doesn't the flash have proper a 4BAIT table?
-michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
prev parent reply other threads:[~2024-04-02 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 11:52 [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g Witold Sadowski
2024-04-02 8:34 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D09HZ0PN0QB9.2TJR29LQ2F570@kernel.org \
--to=mwalle@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=wsadowski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).