From: Carlos Song <carlos.song@nxp.com>
To: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
Bough Chen <haibo.chen@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH] spi: spi-fsl-lpspi: remove redundant spi_controller_put call
Date: Wed, 3 Apr 2024 10:09:19 +0000 [thread overview]
Message-ID: <VI1PR04MB500523F5C08F0D7A86EF07E8E83D2@VI1PR04MB5005.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <3edc4bb76ce0bc96f90cee789e1d0cfd979d356a.camel@siemens.com>
> -----Original Message-----
> From: Sverdlin, Alexander <alexander.sverdlin@siemens.com>
> Sent: Wednesday, April 3, 2024 4:51 PM
> To: broonie@kernel.org; Carlos Song <carlos.song@nxp.com>
> Cc: linux-spi@vger.kernel.org; imx@lists.linux.dev; Bough Chen
> <haibo.chen@nxp.com>; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> Subject: [EXT] Re: [PATCH] spi: spi-fsl-lpspi: remove redundant spi_controller_put
> call
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> Hi Carlos!
>
> On Wed, 2024-04-03 at 16:40 +0800, carlos.song@nxp.com wrote:
> > devm_spi_alloc_controller will allocate an SPI controller and
> > automatically release a reference on it when dev is unbound from its
> > driver. It doesn't need to call spi_controller_put explicitly to put
> > the reference when lpspi driver failed initialization.
> >
> > Fixes: 2ae0ab0143fc ("spi: lpspi: Avoid potential use-after-free in
> > probe()")
> > Signed-off-by: Carlos Song <carlos.song@nxp.com>
>
> You are absolutely right!
> Sorry for the stupid mistake and thanks for the patch!
>
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
Hi, Alexander
It doesn't matter:)!
Thanks for your such quick ack.
BR
Carlos
> > ---
> > drivers/spi/spi-fsl-lpspi.c | 14 ++++++--------
> > 1 file changed, 6 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
> > index 079035db7dd8..92a662d1b55c 100644
> > --- a/drivers/spi/spi-fsl-lpspi.c
> > +++ b/drivers/spi/spi-fsl-lpspi.c
> > @@ -852,39 +852,39 @@ static int fsl_lpspi_probe(struct platform_device
> *pdev)
> > fsl_lpspi->base = devm_platform_get_and_ioremap_resource(pdev,
> 0, &res);
> > if (IS_ERR(fsl_lpspi->base)) {
> > ret = PTR_ERR(fsl_lpspi->base);
> > - goto out_controller_put;
> > + return ret;
> > }
> > fsl_lpspi->base_phys = res->start;
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0) {
> > ret = irq;
> > - goto out_controller_put;
> > + return ret;
> > }
> >
> > ret = devm_request_irq(&pdev->dev, irq, fsl_lpspi_isr, 0,
> > dev_name(&pdev->dev), fsl_lpspi);
> > if (ret) {
> > dev_err(&pdev->dev, "can't get irq%d: %d\n", irq, ret);
> > - goto out_controller_put;
> > + return ret;
> > }
> >
> > fsl_lpspi->clk_per = devm_clk_get(&pdev->dev, "per");
> > if (IS_ERR(fsl_lpspi->clk_per)) {
> > ret = PTR_ERR(fsl_lpspi->clk_per);
> > - goto out_controller_put;
> > + return ret;
> > }
> >
> > fsl_lpspi->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
> > if (IS_ERR(fsl_lpspi->clk_ipg)) {
> > ret = PTR_ERR(fsl_lpspi->clk_ipg);
> > - goto out_controller_put;
> > + return ret;
> > }
> >
> > /* enable the clock */
> > ret = fsl_lpspi_init_rpm(fsl_lpspi);
> > if (ret)
> > - goto out_controller_put;
> > + return ret;
> >
> > ret = pm_runtime_get_sync(fsl_lpspi->dev);
> > if (ret < 0) {
> > @@ -945,8 +945,6 @@ static int fsl_lpspi_probe(struct platform_device
> *pdev)
> > pm_runtime_dont_use_autosuspend(fsl_lpspi->dev);
> > pm_runtime_put_sync(fsl_lpspi->dev);
> > pm_runtime_disable(fsl_lpspi->dev);
> > -out_controller_put:
> > - spi_controller_put(controller);
> >
> > return ret;
> > }
>
> --
> Alexander Sverdlin
> Siemens AG
> http://www.siem/
> ens.com%2F&data=05%7C02%7Ccarlos.song%40nxp.com%7C720beaccc4c94dc
> 67f5a08dc53bb3833%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6
> 38477310781786088%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
> LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata
> =%2BLd5E9xU01iVHHQsoJM9zDbNSpn47cjoNC9yf8qCjjI%3D&reserved=0
next prev parent reply other threads:[~2024-04-03 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 8:40 [PATCH] spi: spi-fsl-lpspi: remove redundant spi_controller_put call carlos.song
2024-04-03 8:51 ` Sverdlin, Alexander
2024-04-03 10:09 ` Carlos Song [this message]
2024-04-03 13:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB500523F5C08F0D7A86EF07E8E83D2@VI1PR04MB5005.eurprd04.prod.outlook.com \
--to=carlos.song@nxp.com \
--cc=alexander.sverdlin@siemens.com \
--cc=broonie@kernel.org \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).