From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Andy Shevchenko <andy@black.fi.intel.com>
Cc: <broonie@kernel.org>, <linus.walleij@linaro.org>, <brgl@bgdev.pl>,
<linux-gpio@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH v4 3/3] spi: cs42l43: Add bridged cs35l56 amplifiers
Date: Wed, 10 Apr 2024 09:11:12 +0000 [thread overview]
Message-ID: <ZhZXsLj4NSjbpbh1@ediswmail9.ad.cirrus.com> (raw)
In-Reply-To: <ZhWIZFvfYb85Pftm@black.fi.intel.com>
On Tue, Apr 09, 2024 at 09:26:44PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 09, 2024 at 02:21:26PM +0100, Charles Keepax wrote:
> > From: Maciej Strozek <mstrozek@opensource.cirrus.com>
> > +#include <linux/acpi.h>
> > +#include <linux/array_size.h>
> > #include <linux/bits.h>
> > #include <linux/bitfield.h>
> > #include <linux/device.h>
> > #include <linux/errno.h>
> > +#include <linux/gpio/machine.h>
>
> Shouldn't you include gpio/property.h as well?
> Ah, in the previous patch you put swnode to consumer.h instead of
> gpio/property.h. Please, fix that.
>
Sorry not sure I follow here, nothing is using
PROPERTY_ENTRY_GPIO and not sure why that is needed in the swnode
patch either?
> > #include <linux/mfd/cs42l43.h>
> > #include <linux/mfd/cs42l43-regs.h>
> > #include <linux/mod_devicetable.h>
>
> > #include <linux/of.h>
> > #include <linux/platform_device.h>
> > #include <linux/pm_runtime.h>
> > +#include <linux/property.h>
> > #include <linux/regmap.h>
> > #include <linux/spi/spi.h>
> > #include <linux/units.h>
>
> ...
>
> > +static const struct software_node ampl = {
> > + .name = "cs35l56-left",
> > +};
> > +
> > +static const struct software_node ampr = {
> > + .name = "cs35l56-right",
> > +};
>
> What these swnodes are for?
>
The two amps we are adding, not sure I entirely follow what you
are asking here. We need the software nodes so we can name the
amps something such that we can find them from the machine driver
later.
> ...
>
> > +static bool cs42l43_has_sidecar(struct fwnode_handle *fwnode)
> > +{
> > + static const u32 func_smart_amp = 0x1;
> > + struct fwnode_handle *child_fwnode, *ext_fwnode;
> > + unsigned int val;
> > + u32 function;
> > + int ret;
> > +
> > + fwnode_for_each_child_node(fwnode, child_fwnode) {
> > + struct acpi_device *adev = to_acpi_device_node(child_fwnode);
> > +
> > + if (!adev)
> > + continue;
> > +
> > + ret = acpi_get_local_address(adev->handle, &function);
> > + if (ret || function != func_smart_amp) {
>
> > + fwnode_handle_put(child_fwnode);
>
> Why?
>
Ah had missed the fwnode_for_each_child will do the put itself,
will fix that up.
> > +MODULE_IMPORT_NS(GPIO_SWNODE);
>
> > +
>
> Stray blank line.
>
Fair enough will remove.
Thanks,
Charles
next prev parent reply other threads:[~2024-04-10 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 13:21 [PATCH 0/3] Add bridged amplifiers to cs42l43 Charles Keepax
2024-04-09 13:21 ` [PATCH v4 1/3] gpio: swnode: Add ability to specify native chip selects for SPI Charles Keepax
2024-04-09 13:50 ` Linus Walleij
2024-04-09 18:03 ` Andy Shevchenko
2024-04-10 8:44 ` Charles Keepax
2024-04-09 13:21 ` [PATCH v4 2/3] spi: Add a mechanism to use the fwnode name for the SPI device Charles Keepax
2024-04-09 14:46 ` Charles Keepax
2024-04-09 18:06 ` Andy Shevchenko
2024-04-10 8:42 ` Charles Keepax
2024-04-09 13:21 ` [PATCH v4 3/3] spi: cs42l43: Add bridged cs35l56 amplifiers Charles Keepax
2024-04-09 18:26 ` Andy Shevchenko
2024-04-10 9:11 ` Charles Keepax [this message]
2024-04-10 7:42 ` kernel test robot
2024-04-10 8:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhZXsLj4NSjbpbh1@ediswmail9.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=andy@black.fi.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).