From: Mark Brown <broonie@kernel.org>
To: Heikki Keranen <heikki.keranen@bittium.com>
Cc: andy.shevchenko@gmail.com, linux-spi@vger.kernel.org,
petri.tauriainen@bittium.com
Subject: Re: [PATCH v2] spi: mux: Fix master controller settings after mux select
Date: Wed, 24 Apr 2024 22:52:28 +0900 [thread overview]
Message-ID: <ZikOnAPi0K20quZS@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20240424111647.81286-1-heikki.keranen@bittium.com>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Wed, Apr 24, 2024 at 02:16:47PM +0300, Heikki Keranen wrote:
> In some cases SPI child devices behind spi-mux require different
> settings like: max_speed_hz, mode and bits_per_word.
Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code. Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-04-24 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 11:41 [PATCH] spi: mux: Fix master controller settings after mux select Heikki Keranen
2024-04-23 5:20 ` Mark Brown
2024-04-23 10:45 ` Andy Shevchenko
2024-04-24 11:16 ` [PATCH v2] " Heikki Keranen
2024-04-24 12:54 ` Andy Shevchenko
2024-04-24 13:52 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZikOnAPi0K20quZS@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=heikki.keranen@bittium.com \
--cc=linux-spi@vger.kernel.org \
--cc=petri.tauriainen@bittium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).