From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Saravana Kannan <saravanak@google.com>,
Gatien Chevallier <gatien.chevallier@foss.st.com>
Cc: <Oleksii_Moisieiev@epam.com>, <gregkh@linuxfoundation.org>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <vkoul@kernel.org>, <jic23@kernel.org>,
<olivier.moysan@foss.st.com>, <arnaud.pouliquen@foss.st.com>,
<mchehab@kernel.org>, <fabrice.gasnier@foss.st.com>,
<andi.shyti@kernel.org>, <ulf.hansson@linaro.org>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<hugues.fruchet@foss.st.com>, <lee@kernel.org>, <will@kernel.org>,
<catalin.marinas@arm.com>, <arnd@kernel.org>,
<richardcochran@gmail.com>, Frank Rowand <frowand.list@gmail.com>,
<peng.fan@oss.nxp.com>, <lars@metafoo.de>, <rcsekar@samsung.com>,
<wg@grandegger.com>, <mkl@pengutronix.de>,
<linux-crypto@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<alsa-devel@alsa-project.org>, <linux-media@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <linux-serial@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-usb@vger.kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v9 06/13] of: property: fw_devlink: Add support for "access-controller"
Date: Wed, 24 Apr 2024 14:19:18 +0200 [thread overview]
Message-ID: <a0bd94ce-3ddb-4448-ada9-7070323cc98f@foss.st.com> (raw)
In-Reply-To: <CAGETcx8HdnspNfDEJP+cqShJPsDryzGkOVq6B99cFQzkZi3dMg@mail.gmail.com>
Hi Saravana
On 4/24/24 07:57, Saravana Kannan wrote:
> On Fri, Jan 5, 2024 at 5:03 AM Gatien Chevallier
> <gatien.chevallier@foss.st.com> wrote:
>>
>> Allows tracking dependencies between devices and their access
>> controller.
>>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> Please cc me on fw_devlink patches. Also, this patch is breaking the
> norm below. Please send a fix up patch.
>
>> ---
>> Changes in V9:
>> - Added Rob's review tag
>>
>> Changes in V6:
>> - Renamed access-controller to access-controllers
>>
>> Changes in V5:
>> - Rename feature-domain* to access-control*
>>
>> Patch not present in V1
>>
>> drivers/of/property.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/of/property.c b/drivers/of/property.c
>> index afdaefbd03f6..7f737eac91b2 100644
>> --- a/drivers/of/property.c
>> +++ b/drivers/of/property.c
>> @@ -1268,6 +1268,7 @@ DEFINE_SIMPLE_PROP(leds, "leds", NULL)
>> DEFINE_SIMPLE_PROP(backlight, "backlight", NULL)
>> DEFINE_SIMPLE_PROP(panel, "panel", NULL)
>> DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells")
>> +DEFINE_SIMPLE_PROP(access_controllers, "access-controllers", "#access-controller-cells")
>> DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
>> DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
>>
>> @@ -1363,6 +1364,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
>> { .parse_prop = parse_regulators, },
>> { .parse_prop = parse_gpio, },
>> { .parse_prop = parse_gpios, },
>> + { .parse_prop = parse_access_controllers, },
>
> All the simple properties are listed before the suffix ones as the
> suffix checks are more expensive. So, you should have inserted this
> right before the suffix properties. Also, there's a merge conflict in
> linux-next. So make sure you take that into account when sending the
> fix up and picking the order.
I'm fixing the stm32-next branch by inserting
{ .parse_prop = parse_access_controllers, },
just before
{ .parse_prop = parse_regulators, },
>
> -Saravana
>
>> {}
>> };
>
>>
>> --
>> 2.35.3
>>
next prev parent reply other threads:[~2024-04-24 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 13:03 [PATCH v9 00/13] Introduce STM32 Firewall framework Gatien Chevallier
2024-01-05 13:03 ` [PATCH v9 01/13] dt-bindings: document generic access controllers Gatien Chevallier
2024-01-05 13:03 ` [PATCH v9 02/13] dt-bindings: treewide: add access-controllers description Gatien Chevallier
2024-01-19 22:06 ` Rob Herring
2024-01-05 13:03 ` [PATCH v9 03/13] dt-bindings: bus: document RIFSC Gatien Chevallier
2024-01-05 13:03 ` [PATCH v9 04/13] dt-bindings: bus: document ETZPC Gatien Chevallier
2024-01-05 13:03 ` [PATCH v9 05/13] firewall: introduce stm32_firewall framework Gatien Chevallier
2024-01-05 13:03 ` [PATCH v9 06/13] of: property: fw_devlink: Add support for "access-controller" Gatien Chevallier
2024-04-24 5:57 ` Saravana Kannan
2024-04-24 12:19 ` Alexandre TORGUE [this message]
2024-01-05 13:03 ` [PATCH v9 07/13] bus: rifsc: introduce RIFSC firewall controller driver Gatien Chevallier
2024-01-05 13:03 ` [PATCH v9 08/13] arm64: dts: st: add RIFSC as an access controller for STM32MP25x boards Gatien Chevallier
2024-01-05 13:04 ` [PATCH v9 09/13] bus: etzpc: introduce ETZPC firewall controller driver Gatien Chevallier
2024-01-05 13:04 ` [PATCH v9 10/13] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards Gatien Chevallier
2024-01-05 13:04 ` [PATCH v9 11/13] ARM: dts: stm32: put ETZPC as an access controller " Gatien Chevallier
2024-01-05 13:04 ` [PATCH v9 12/13] ARM: dts: stm32: add ETZPC as a system bus for STM32MP13x boards Gatien Chevallier
2024-01-05 13:04 ` [PATCH v9 13/13] ARM: dts: stm32: put ETZPC as an access controller " Gatien Chevallier
2024-04-08 8:42 ` [PATCH v9 00/13] Introduce STM32 Firewall framework Alexandre TORGUE
2024-04-09 17:13 ` Rob Herring
2024-04-11 9:37 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0bd94ce-3ddb-4448-ada9-7070323cc98f@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=Oleksii_Moisieiev@epam.com \
--cc=alsa-devel@alsa-project.org \
--cc=andi.shyti@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=arnd@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=frowand.list@gmail.com \
--cc=gatien.chevallier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hugues.fruchet@foss.st.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=olivier.moysan@foss.st.com \
--cc=pabeni@redhat.com \
--cc=peng.fan@oss.nxp.com \
--cc=rcsekar@samsung.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wg@grandegger.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).