From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Qingfang Deng <dqfext@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Qingfang Deng <qingfang.deng@siflower.com.cn>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] spi: dt-bindings: add Siflower Quad SPI controller
Date: Tue, 2 Apr 2024 15:12:59 +0200 [thread overview]
Message-ID: <f52f3d30-4ddd-4338-b4f7-c316633b7c4b@linaro.org> (raw)
In-Reply-To: <c4df0a94-be48-464f-892a-7157cb30f034@sirena.org.uk>
On 02/04/2024 14:22, Mark Brown wrote:
> On Sat, Mar 30, 2024 at 06:42:11PM +0100, Krzysztof Kozlowski wrote:
>> On 29/03/2024 02:51, Qingfang Deng wrote:
>
>>> Add YAML devicetree bindings for Siflower Quad SPI controller.
>
>> Describe the hardware. What is this Siflower?
>
> That seems like a perfectly adequate description - ${VENDOR} ${FUNCTION}
> is normal enough and Quad SPI is a well known standard. We don't need a
> marketing spiel for whatever IP version is currently supported.
What we are missing here is the final product, so for example the SoC.
Is the company making exactly one and only one Quad SPI? I provided more
explanation what is missing further in the quoted email and in follow up
email/discussion.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-02 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 1:51 [RFC PATCH 1/2] spi: dt-bindings: add Siflower Quad SPI controller Qingfang Deng
2024-03-29 1:51 ` [RFC PATCH 2/2] spi: " Qingfang Deng
2024-03-29 3:27 ` [RFC PATCH 1/2] spi: dt-bindings: " Rob Herring
2024-03-29 5:46 ` [RFC PATCH v2 " Qingfang Deng
2024-03-29 5:46 ` [RFC PATCH v2 2/2] spi: " Qingfang Deng
2024-03-30 17:43 ` [RFC PATCH v2 1/2] spi: dt-bindings: " Krzysztof Kozlowski
2024-03-30 17:42 ` [RFC PATCH " Krzysztof Kozlowski
2024-04-01 3:36 ` Qingfang Deng
2024-04-01 9:53 ` Krzysztof Kozlowski
2024-04-02 12:22 ` Mark Brown
2024-04-02 13:12 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f52f3d30-4ddd-4338-b4f7-c316633b7c4b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=qingfang.deng@siflower.com.cn \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).