From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FA3070 for ; Fri, 21 May 2021 20:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621628764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=538ECF91gJCkNsV6K0m49/DR+WsCYP9T9kKj+WEgQUw=; b=cSAL+eAFsA3PdoLglROQ5gDza85F+u2vXskQY/GoM4k4D5Gq/i4WIrC+Ghtz36jv+yuCoM YKS4i6hkt8/hDs104zmbfVZSs4qNsft/j5oWgnzEGoH2Ec3/Sruqv1x6ddm8zjACkdvUXy 5chuVHBJJdDH0w5EAas+wqwYp+86E7o= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-Onq7n6xROkawZyp_iBKHHg-1; Fri, 21 May 2021 16:26:03 -0400 X-MC-Unique: Onq7n6xROkawZyp_iBKHHg-1 Received: by mail-ed1-f72.google.com with SMTP id b8-20020a05640202c8b029038f1782a77eso3441086edx.15 for ; Fri, 21 May 2021 13:26:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=538ECF91gJCkNsV6K0m49/DR+WsCYP9T9kKj+WEgQUw=; b=Q8u4fPHn9I3733q613im0sLRtQnIipf8JHW8z6th0jc88TRwPmyXuRd00oWQXjQ69a cvWGxKOxvg8wl+5u6BXxrBSa+gC8LH/hZQrvRDd7lZQDZhckp/985fnjyHTbWZ7HP145 MbzuVZAwZFEOt2FmpjX6H/DGfuu4yl3gGE/vPFQhUp4L15tyfVWUoX/o/Fe2IVUINQFv Wy+bpNyLmj+5umOHHhrFXJQLjU0g9p/18oVBRMgkMB2TjewBD2etVoXaBM66QAS3wvro 4UKhf7go2SDx2Eod6XTtMFDcrXgyE/+g9Fz/98WiUZaVpvxI3YgkumlLbjJJzuNt/JEf t8GQ== X-Gm-Message-State: AOAM532fa5ELRmBzFb5mSn4DAbEmyHK8PvU1z2pgPPACb2mrlWDUtEiN WY8hPnlaA0/Htn8q9A/oszZ33L57nUzCU/6+QqBQhWNoo2+DCYCHyFUnKOBPmOu3sTmXKg+kPMj eh1RXILUMNFRb6YgTOuM8kOdzuVWpar4bTGiEPv2ejo+Ylao9upkWJOrAJdLrXf2TOCE/makI1n XlIA== X-Received: by 2002:a17:906:408d:: with SMTP id u13mr3539588ejj.128.1621628761598; Fri, 21 May 2021 13:26:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWdTt0OF6CxsPUnwkdM+BeqLBz1MEl7r1QIb+Pld1fs/jKvj4IlpWl2lFYHMg6LfydV3c3fQ== X-Received: by 2002:a17:906:408d:: with SMTP id u13mr3539559ejj.128.1621628761262; Fri, 21 May 2021 13:26:01 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id l28sm4751766edc.29.2021.05.21.13.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 May 2021 13:26:00 -0700 (PDT) To: Greg KH Cc: Palmer Dabbelt , anup@brainfault.org, Anup Patel , Paul Walmsley , aou@eecs.berkeley.edu, corbet@lwn.net, graf@amazon.com, Atish Patra , Alistair Francis , Damien Le Moal , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: From: Paolo Bonzini Subject: Re: [PATCH v18 00/18] KVM RISC-V Support Message-ID: <00d96cc3-026e-bd78-db08-f9e98a4abeff@redhat.com> Date: Fri, 21 May 2021 22:25:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 21/05/21 19:47, Greg KH wrote: > If this isn't in any hardware that anyone outside of > internal-to-company-prototypes, then let's wait until it really is in a > device that people can test this code on. > > What's the rush to get this merged now if no one can use it? There is not just hardware, there are simulators and emulators too (you can use QEMU to test it for example), and it's not exactly a rush since it's basically been ready for 2 years and has hardly seen any code changes since v13 which was based on Linux 5.9. Not having the code upstream is hindering further development so that RISC-V KVM can be feature complete when hardware does come out. Missing features and optimizations could be added on top, but they are harder to review if they are integrated in a relatively large series instead of being done incrementally. Not having the header files in Linus's tree makes it harder to merge RISC-V KVM support in userspace (userspace is shielded anyway by any future changes to the hypervisor specification, so there's no risk of breaking the ABI). At some point one has to say enough is enough; for me, that is after one year with no changes to the spec and, especially, no deadline in sight for freezing it. The last 5 versions of the patch set were just adapting to changes in the generic KVM code. If the code is good, I don't see why the onus of doing those changes should be on Anup, rather than being shared amongst all KVM developers as is the case for all the other architectures. Paolo