From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, forest@alittletooquiet.net,
linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com
Subject: Re: [PATCH v2 0/5] staging: Fix parameters alignment
Date: Mon, 4 Mar 2024 16:55:50 +0300 [thread overview]
Message-ID: <08387340-4611-4403-b38f-75d63eb06d2a@moroto.mountain> (raw)
In-Reply-To: <20240304124006.26819-1-dorine.a.tipo@gmail.com>
On Mon, Mar 04, 2024 at 12:40:01PM +0000, Dorine Tipo wrote:
> Hello!
>
> This V2 patch series addresses inconsistencies in parameter alignment with
> open parantheses, enhancing readability and maintainability of the code.
> The patch series includes updates to multiple files in the staging
> directory. Each patch focuses on specific functions or sections of code to
> ensure comprehensive coverage of the alignment improvements.
>
> Patch 1 fixes the parameter alignment in cvmx_spi_restart_interface() in
> octeon-stubs.h in the octeon driver
> Patches 2-6 fix the alignment of parameters in various functions inside
> card.c in the vt6655 driver
>
> Changelog:
> - V2: Modified subjects to be unique for each patch, as requested by
> greg k-h
> - Fixed the warnings in the patches as suggested by Philipp
>
>
> Dorine Tipo (5):
> Staging: octeon: Match parenthesis alignment
Do the octeon patch as a separate patchset. It's a totally different
driver.
> staging: vt6655: Correct parameters alignment
> staging: vt6655: Align parameters with parenthesis
> staging: vt6655: Match open parenthesis alignment
> staging: vt6655: Fix open parenthesis alignment
Combine all these patches into one patch. The rule is "one thing per
patch" not "one line per patch".
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-04 13:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 6:56 [PATCH] staging: vt6655: Match parenthesis alignment Dorine Tipo
2024-03-03 19:30 ` Greg KH
2024-03-04 12:40 ` [PATCH v2 0/5] staging: Fix parameters alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 1/5] Staging: octeon: Match parenthesis alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 2/5] staging: vt6655: Correct parameters alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 3/5] staging: vt6655: Align parameters with parenthesis Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 4/5] staging: vt6655: Match open parenthesis alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 5/5] staging: vt6655: Fix " Dorine Tipo
2024-03-04 13:55 ` Dan Carpenter [this message]
2024-03-04 14:26 ` [PATCH v3 0/1] Staging: vt6655: Parameter Alignment Improvements Dorine Tipo
2024-03-04 14:26 ` [PATCH v3 1/1] staging: vt6655: Correct parameters alignment Dorine Tipo
2024-03-04 20:53 ` Philipp Hortmann
2024-03-05 4:53 ` [PATCH v4] staging: vt6655: Match open parentheses Dorine Tipo
2024-03-05 8:10 ` [PATCH v3 1/1] staging: vt6655: Correct parameters alignment Dan Carpenter
2024-03-05 9:14 ` [PATCH v5] staging: vt6655: Match open parentheses Dorine Tipo
2024-03-05 9:32 ` [PATCH v6] " Dorine Tipo
2024-03-05 22:01 ` Philipp Hortmann
2024-03-06 4:59 ` Dan Carpenter
2024-03-06 5:40 ` Philipp Hortmann
2024-03-04 14:49 ` [PATCH V3] Staging: octeon: match parentheses alignment Dorine Tipo
2024-03-04 17:50 ` Greg KH
2024-03-05 5:14 ` [PATCH v4] Staging: octeon: Match parenthesis alignment Dorine Tipo
2024-03-05 9:23 ` [PATCH v5] " Dorine Tipo
2024-03-05 9:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08387340-4611-4403-b38f-75d63eb06d2a@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=dorine.a.tipo@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).