From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Chen shuo <1289151713@qq.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: remove the r8192E_dev.c's unnecessary brace
Date: Thu, 9 May 2024 09:51:32 +0200 [thread overview]
Message-ID: <190dcc76-7753-4191-8578-482c2942583d@gmail.com> (raw)
In-Reply-To: <tencent_1992979C468AF087A1909000C6D0D5E61207@qq.com>
On 5/8/24 17:13, Chen shuo wrote:
> There is a unnecessary brace in r8192E_dev.c.Remove it to shorten
> code and improve readability.
>
> Signed-off-by: Chen shuo <1289151713@qq.com>
> ---
> v2:Make "Subject" line more unique.
> Add space after : and driver name in the subject.
>
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index e3ed709a7674..1862a9899966 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1640,9 +1640,8 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
> if (stats->Length < 24)
> stats->bHwError |= 1;
>
> - if (stats->bHwError) {
> + if (stats->bHwError)
> return false;
> - }
>
> stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
> stats->RxBufShift = (pdesc->Shift) & 0x03;
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2024-05-09 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:13 [PATCH v2] staging: rtl8192e: remove the r8192E_dev.c's unnecessary brace Chen shuo
2024-05-09 7:51 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190dcc76-7753-4191-8578-482c2942583d@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=1289151713@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).