From: Greg KH <gregkh@linuxfoundation.org>
To: Chandra Pratap <chandrapratap3519@gmail.com>
Cc: sudipm.mukherjee@gmail.com, dan.carpenter@linaro.org,
teddy.wang@siliconmotion.com, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v3] staging: sm750fb: Replace comparisons with NULL and 0
Date: Fri, 22 Mar 2024 15:25:37 +0100 [thread overview]
Message-ID: <2024032226-gorgeous-snowbird-25b1@gregkh> (raw)
In-Reply-To: <20240322141031.2776-1-chandrapratap3519@gmail.com>
On Fri, Mar 22, 2024 at 07:40:31PM +0530, Chandra Pratap wrote:
> Replace '(opt != NULL)' with '(opt)' and '(*opt != 0)'
> with '(*opt != '\0')' to adhere to the coding standards.
>
> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 04c1b32a22c5..c4b944f82fb9 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -926,7 +926,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
> goto NO_PARAM;
> }
>
> - while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
> + while ((opt = strsep(&src, ":")) && *opt != '\0') {
> dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt);
> dev_info(&sm750_dev->pdev->dev, "src=%s\n", src);
>
> @@ -1147,7 +1147,7 @@ static int __init lynxfb_setup(char *options)
> * strsep() updates @options to pointer after the first found token
> * it also returns the pointer ahead the token.
> */
> - while ((opt = strsep(&options, ":")) != NULL) {
> + while ((opt = strsep(&options, ":"))) {
> /* options that mean for any lynx chips are configured here */
> if (!strncmp(opt, "noaccel", strlen("noaccel"))) {
> g_noaccel = 1;
> --
> 2.34.1
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2024-03-22 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 18:17 [PATCH] staging: sm750fb: Replace comparisons with NULL and 0 Chandra Pratap
2024-03-20 5:08 ` Dan Carpenter
2024-03-20 18:09 ` [PATCH v2] " Chandra Pratap
2024-03-21 5:41 ` Dan Carpenter
2024-03-22 9:49 ` Greg KH
2024-03-22 14:10 ` [PATCH v3] " Chandra Pratap
2024-03-22 14:25 ` Greg KH [this message]
2024-03-22 15:16 ` Chandra Pratap
2024-03-23 2:59 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032226-gorgeous-snowbird-25b1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chandrapratap3519@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).