From: Ricardo Ribalda <ribalda@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH 0/3] media: Fix gcc warnings
Date: Sat, 23 Mar 2024 10:41:44 +0000 [thread overview]
Message-ID: <20240323-gcc-arm-warnings-v1-0-0b45cc52f39e@chromium.org> (raw)
drivers/staging/media/tegra-video/tegra20.c: In function ‘tegra20_vip_start_streaming’:
drivers/staging/media/tegra-video/tegra20.c:624:72: warning: ‘yuv_input_format’ may be used uninitialized [-Wmaybe-uninitialized]
624 | VI_INPUT_VIP_INPUT_ENABLE | main_input_format | yuv_input_format);
drivers/staging/media/tegra-video/tegra20.c:617:22: note: ‘yuv_input_format’ was declared here
617 | unsigned int yuv_input_format;
| ^~~~~~~~~~~~~~~~
drivers/media/radio/radio-shark2.c: In function ‘usb_shark_probe’:
drivers/media/radio/radio-shark2.c:191:17: warning: ‘%s’ directive output may be truncated writing up to 35 bytes into a region of size 32 [-Wformat-truncation=]
191 | .name = "%s:blue:",
| ^
In function ‘shark_register_leds’,
inlined from ‘usb_shark_probe’ at drivers/media/radio/radio-shark2.c:306:11:
drivers/media/radio/radio-shark2.c:212:17: note: ‘snprintf’ output between 7 and 42 bytes into a destination of size 32
212 | snprintf(shark->led_names[i], sizeof(shark->led_names[0]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
213 | shark->leds[i].name, shark->v4l2_dev.name);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/radio/radio-shark2.c: In function ‘usb_shark_probe’:
drivers/media/radio/radio-shark2.c:197:17: warning: ‘%s’ directive output may be truncated writing up to 35 bytes into a region of size 32 [-Wformat-truncation=]
197 | .name = "%s:red:",
| ^
In function ‘shark_register_leds’,
inlined from ‘usb_shark_probe’ at drivers/media/radio/radio-shark2.c:306:11:
drivers/media/radio/radio-shark2.c:212:17: note: ‘snprintf’ output between 6 and 41 bytes into a destination of size 32
212 | snprintf(shark->led_names[i], sizeof(shark->led_names[0]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
213 | shark->leds[i].name, shark->v4l2_dev.name);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
AR drivers/staging/media/tegra-video/built-in.a
AR drivers/staging/media/built-in.a
In file included from ./include/asm-generic/preempt.h:5,
from ./arch/arm/include/generated/asm/preempt.h:1,
from ./include/linux/preempt.h:79,
from ./include/linux/spinlock.h:56,
from ./include/linux/mmzone.h:8,
from ./include/linux/gfp.h:7,
from ./include/linux/umh.h:4,
from ./include/linux/kmod.h:9,
from ./include/linux/module.h:17,
from drivers/media/dvb-core/dvbdev.c:15:
In function ‘check_object_size’,
inlined from ‘check_copy_size’ at ./include/linux/thread_info.h:251:2,
inlined from ‘copy_from_user’ at ./include/linux/uaccess.h:182:6,
inlined from ‘dvb_usercopy’ at drivers/media/dvb-core/dvbdev.c:987:7:
./include/linux/thread_info.h:215:17: warning: ‘sbuf’ may be used uninitialized [-Wmaybe-uninitialized]
215 | __check_object_size(ptr, n, to_user);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/thread_info.h: In function ‘dvb_usercopy’:
./include/linux/thread_info.h:208:13: note: by argument 1 of type ‘const void *’ to ‘__check_object_size’ declared here
208 | extern void __check_object_size(const void *ptr, unsigned long n,
| ^~~~~~~~~~~~~~~~~~~
drivers/media/dvb-core/dvbdev.c:959:17: note: ‘sbuf’ declared here
959 | char sbuf[128];
| ^~~~
AR drivers/media/radio/built-in.a
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Ricardo Ribalda (3):
staging: media: tegra-video: Fix -Wmaybe-unitialized warn in gcc
media: radio-shark2: Avoid led_names truncations
media: dvbdev: Initialize sbuf
drivers/media/dvb-core/dvbdev.c | 2 +-
drivers/media/radio/radio-shark2.c | 2 +-
drivers/staging/media/tegra-video/tegra20.c | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
---
base-commit: b14257abe7057def6127f6fb2f14f9adc8acabdb
change-id: 20240323-gcc-arm-warnings-e4c142cb5ac0
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
next reply other threads:[~2024-03-23 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 10:41 Ricardo Ribalda [this message]
2024-03-23 10:41 ` [PATCH 1/3] staging: media: tegra-video: Fix -Wmaybe-unitialized warn in gcc Ricardo Ribalda
2024-03-25 13:46 ` Thierry Reding
2024-03-23 10:41 ` [PATCH 2/3] media: radio-shark2: Avoid led_names truncations Ricardo Ribalda
2024-03-23 10:41 ` [PATCH 3/3] media: dvbdev: Initialize sbuf Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240323-gcc-arm-warnings-v1-0-0b45cc52f39e@chromium.org \
--to=ribalda@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).