From: Greg KH <gregkh@linuxfoundation.org>
To: Yuguo Pei <purofle@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset
Date: Tue, 9 Apr 2024 19:36:18 +0200 [thread overview]
Message-ID: <2024040938-balcony-catapult-5c10@gregkh> (raw)
In-Reply-To: <20240409172806.8527-1-purofle@gmail.com>
On Wed, Apr 10, 2024 at 01:28:06AM +0800, Yuguo Pei wrote:
> On Tue, 9 Apr 2024 17:49:25 +0200, Greg KH wrote:
> > So you are now hard-coding the size?
>
> Yes, the change just helps developers who want to adapt to different screen sizes.
So there is no change? I don't understand.
> > Is this always going to be 0, if so, why need it at all?
>
> Not sure. For example, when HEIGHT and WIDTH are 240 and 280, LEFT_OFFSET is 20 and TOP_OFFSET is 0. Different screens may have different offsets.
Then why is this needed?
Don't make changes that are not needed by anyone, especially for code in
drivers/staging/
>
> In addition, do I need to resend the patch to modify the Signed-off-by?
Of course you do :)
next prev parent reply other threads:[~2024-04-09 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 16:57 [PATCH] staging: fbtft: fb_st7789v: support setting offset purofle
2024-04-09 15:49 ` Greg KH
2024-04-09 17:28 ` Yuguo Pei
2024-04-09 17:36 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-09 16:39 purofle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024040938-balcony-catapult-5c10@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=purofle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).