From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-staging@lists.linux.dev
Cc: Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>, Greg KH <greg@kroah.com>,
Stefan Wahren <wahrenst@gmx.net>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: [PATCH v5 00/11] staging: vc04_services: Drop non-essential global members
Date: Fri, 12 Apr 2024 13:27:32 +0530 [thread overview]
Message-ID: <20240412075743.60712-1-umang.jain@ideasonboard.com> (raw)
This series aims to drop the remaining (non-essential) global members
to address the following TODO item:
```
* Get rid of all non essential global structures and create a proper per
device structure
```
Mainly the global members are moved to be contained inside platform
driver data. They can be access via platform_get_drvdata().
More re-fractoring has gone into this version now. Please look
for individual commit for details.
Testing on top of RPi 3 with staging next.
Changes in v5:
- Rebase over latest staging-testing that contains kthreads revert [2]
- commit messages fixup
- Add suggested-by in 5/11
- Use spinlock_t(typedef) instead of 'struct spinlock_t' in 8/11
Changes in v4:
- New patch to drop vchiq_connected.[ch] files and move the functions
to vchiq_arm.c (5/11)
- De-globalise remapped memory region pointer (7/11)
- De-globalise global spinlocks too (8/11)
- De-globalise global vchiq_pointer g_state (10/11)
- commit message updates and trivial variable renaming
Changes in v3:
- Rework 2/6 to 5/6 as per Laurent's review in v2 [1].
- Add a comment for g_regs global __iomem ptr.
Changes in v2:
- Found even more g_* global variables than v1, so new patches to drop
them
- Introduce 1/6 as suggested during v1 review
- Introuce 6/6 to cleanup the TODO list
[1]: https://lore.kernel.org/linux-staging/4ba0d745-fc8d-4886-b71a-1f19962e9103@moroto.mountain/T/#m440ee992442cc82ea43092b7c895823c918d105f
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=ebee9ca2f59e35a60a6704a79df6477b3c84ac96
Umang Jain (11):
staging: vc04_services: Drop g_once_init global variable
staging: vc04_services: vchiq_arm: Split driver static and runtime
data
staging: vc04_services: vchiq_arm: Drop g_cache_line_size
staging: vc04_services: Move variables for tracking connections
staging: vc04_services: Drop vchiq_connected.[ch] files
staging: vc04_services: Move global variables tracking allocated pages
staging: vc04_services: Move global memory mapped pointer
staging: vc04_services: Move spinlocks to vchiq_state
staging: vc04_services: vchiq_mmal: Rename service_callback()
staging: vc04_services: Move global g_state to vchiq_state
staging: vc04_services: Drop completed TODO item
drivers/staging/vc04_services/Makefile | 1 -
.../bcm2835-audio/bcm2835-vchiq.c | 5 +-
.../bcm2835-camera/bcm2835-camera.c | 4 +-
.../include/linux/raspberrypi/vchiq.h | 4 +-
drivers/staging/vc04_services/interface/TODO | 15 --
.../interface/vchiq_arm/vchiq_arm.c | 252 ++++++++++--------
.../interface/vchiq_arm/vchiq_arm.h | 41 ++-
.../interface/vchiq_arm/vchiq_bus.c | 3 +
.../interface/vchiq_arm/vchiq_bus.h | 3 +
.../interface/vchiq_arm/vchiq_connected.c | 74 -----
.../interface/vchiq_arm/vchiq_connected.h | 12 -
.../interface/vchiq_arm/vchiq_core.c | 51 ++--
.../interface/vchiq_arm/vchiq_core.h | 11 +-
.../interface/vchiq_arm/vchiq_debugfs.c | 5 +-
.../interface/vchiq_arm/vchiq_dev.c | 34 +--
.../vc04_services/vchiq-mmal/mmal-vchiq.c | 14 +-
.../vc04_services/vchiq-mmal/mmal-vchiq.h | 3 +-
17 files changed, 255 insertions(+), 277 deletions(-)
delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h
base-commit: e4d5e3a9ae68250f7cc7e930ffeecba2c9f32832
--
2.44.0
next reply other threads:[~2024-04-12 7:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 7:57 Umang Jain [this message]
2024-04-12 7:57 ` [PATCH v5 01/11] staging: vc04_services: Drop g_once_init global variable Umang Jain
2024-04-14 10:23 ` Stefan Wahren
2024-04-12 7:57 ` [PATCH v5 02/11] staging: vc04_services: vchiq_arm: Split driver static and runtime data Umang Jain
2024-04-14 12:04 ` Stefan Wahren
2024-04-19 13:58 ` Stefan Wahren
2024-04-12 7:57 ` [PATCH v5 03/11] staging: vc04_services: vchiq_arm: Drop g_cache_line_size Umang Jain
2024-04-14 12:09 ` Stefan Wahren
2024-04-19 14:04 ` Stefan Wahren
2024-04-21 8:58 ` Umang Jain
2024-04-12 7:57 ` [PATCH v5 04/11] staging: vc04_services: Move variables for tracking connections Umang Jain
2024-04-14 10:41 ` Stefan Wahren
2024-04-12 7:57 ` [PATCH v5 05/11] staging: vc04_services: Drop vchiq_connected.[ch] files Umang Jain
2024-04-12 7:57 ` [PATCH v5 06/11] staging: vc04_services: Move global variables tracking allocated pages Umang Jain
2024-04-14 11:45 ` Stefan Wahren
2024-04-12 7:57 ` [PATCH v5 07/11] staging: vc04_services: Move global memory mapped pointer Umang Jain
2024-04-14 11:58 ` Stefan Wahren
2024-04-16 6:42 ` Laurent Pinchart
2024-04-12 7:57 ` [PATCH v5 08/11] staging: vc04_services: Move spinlocks to vchiq_state Umang Jain
2024-04-14 11:59 ` Stefan Wahren
2024-04-12 7:57 ` [PATCH v5 09/11] staging: vc04_services: vchiq_mmal: Rename service_callback() Umang Jain
2024-04-14 11:06 ` Stefan Wahren
2024-04-12 7:57 ` [PATCH v5 10/11] staging: vc04_services: Move global g_state to vchiq_state Umang Jain
2024-04-14 11:26 ` Stefan Wahren
2024-04-12 7:57 ` [PATCH v5 11/11] staging: vc04_services: Drop completed TODO item Umang Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412075743.60712-1-umang.jain@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=greg@kroah.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).