From: Greg KH <gregkh@linuxfoundation.org>
To: sumadhura kalyan <opensourcecond@gmail.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vc04_services: Code optimized to use linux BIT macro.
Date: Sun, 14 Apr 2024 12:17:56 +0200 [thread overview]
Message-ID: <2024041419-rug-undrilled-6628@gregkh> (raw)
In-Reply-To: <20240414101258.98358-1-opensourcecond@gmail.com>
On Sun, Apr 14, 2024 at 03:42:58PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
>
> Signed-off-by: sumadhura kalyan <opensourcecond@gmail.com>
> ---
> drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> index a0cdd28101f2..d811bfd3bb84 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> @@ -27,7 +27,7 @@
> /** Common parameter ID group, used with many types of component. */
> #define MMAL_PARAMETER_GROUP_COMMON (0 << 16)
> /** Camera-specific parameter ID group. */
> -#define MMAL_PARAMETER_GROUP_CAMERA (1 << 16)
> +#define MMAL_PARAMETER_GROUP_CAMERA BIT(16)
> /** Video-specific parameter ID group. */
> #define MMAL_PARAMETER_GROUP_VIDEO (2 << 16)
> /** Audio-specific parameter ID group. */
When looking at the code now, does this change make sense? Remember,
checkpatch is a guide, not a hard rule.
greg k-h
prev parent reply other threads:[~2024-04-14 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 10:12 [PATCH] staging: vc04_services: Code optimized to use linux BIT macro sumadhura kalyan
2024-04-14 10:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041419-rug-undrilled-6628@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=opensourcecond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).