From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH v3 1/8] Staging: sm750fb: Rename sii164ResetChip
Date: Thu, 7 Mar 2024 17:06:50 +0300 [thread overview]
Message-ID: <27f1ca39-3747-41cf-bf5c-7536d9998afe@moroto.mountain> (raw)
In-Reply-To: <20240306054458.102288-2-dorine.a.tipo@gmail.com>
On Wed, Mar 06, 2024 at 05:44:51AM +0000, Dorine Tipo wrote:
> Rename variable sii164ResetChip to sii164_reset_chip to silence
> checkpatch warning Avoid CamelCase
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> V2: Added the patch to a series.
> Fixed errors within the patch.
> Compiled the kernel
>
> V3: Reverted a commit in the same patch series
You we can't revert a patch which was never applied. Please wait at
least a day between resends.
>
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index 3fb14eff2de1..6dee95e60a6e 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
> .get_vendor_id = sii164_get_vendor_id,
> .get_device_id = sii164_get_device_id,
> #ifdef SII164_FULL_FUNCTIONS
> - .reset_chip = sii164ResetChip,
> + .reset_chip = sii164_reset_chip,
From looking at this patch you would assume that it would break the
build but actually it seems that SII164_FULL_FUNCTIONS is never defined.
The advice is always to just delete dead code.
We can't apply any of these patches...
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-07 14:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 5:44 [PATCH v3 0/8] Rename variables in sm750fb driver Dorine Tipo
2024-03-06 5:44 ` [PATCH v3 1/8] Staging: sm750fb: Rename sii164ResetChip Dorine Tipo
2024-03-07 14:06 ` Dan Carpenter [this message]
2024-03-07 14:21 ` Greg KH
2024-03-08 9:10 ` Apology and Request for Resubmitting Patch Dorine Tipo
2024-03-08 9:52 ` Julia Lawall
2024-03-09 12:48 ` Dan Carpenter
2024-03-06 5:44 ` [PATCH v3 2/8] Staging: sm750fb: Rename variable sii164GetChipString Dorine Tipo
2024-03-06 5:44 ` [PATCH v3 3/8] Staging: sm750fb: Rename variable sii164SetPower Dorine Tipo
2024-03-06 5:44 ` [PATCH v3 4/8] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection Dorine Tipo
2024-03-06 5:44 ` [PATCH v3 5/8] Staging: sm750fb: Rename variable sii164IsConnected Dorine Tipo
2024-03-06 5:44 ` [PATCH v3 6/8] Staging: sm750fb: Rename variable sii164CheckInterrupt Dorine Tipo
2024-03-06 5:44 ` [PATCH v3 7/8] Staging: sm750fb: Rename Variable sii164ClearInterrupt Dorine Tipo
2024-03-06 5:44 ` [PATCH v3 8/8] Revert "Staging: sm750fb: Rename variable sii164GetDeviceID" Dorine Tipo
2024-03-07 14:20 ` Greg KH
2024-03-07 17:12 ` [PATCH v3 0/8] Rename variables in sm750fb driver Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f1ca39-3747-41cf-bf5c-7536d9998afe@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).