From: Stefan Wahren <wahrenst@gmx.net>
To: Umang Jain <umang.jain@ideasonboard.com>, linux-staging@lists.linux.dev
Cc: Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>, Greg KH <greg@kroah.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2] Revert "staging: vc04_services: vchiq_core: Stop kthreads on shutdown"
Date: Fri, 5 Apr 2024 12:24:07 +0200 [thread overview]
Message-ID: <34b14772-1386-44f4-bb7e-e3f6cf137971@gmx.net> (raw)
In-Reply-To: <20240403052100.2794-1-umang.jain@ideasonboard.com>
Am 03.04.24 um 07:21 schrieb Umang Jain:
> This reverts commit d9c60badccc183eb971e0941bb86f9475d4b9551.
>
> It has been reported that stopping kthreads corrupts the VC04 firmware
> and creates issues at boot time [1].
>
> A fix-up version of this patch
> bac670144384 ("staging: vc04_services: Stop kthreads on .remove") [2]
> was also attempted but it also doesn't properly fix the TODO
> (i.e. clean module unload) and similar errors were observed when
> stopping these khthreads on RaspberryPi 3.
>
> Hence, revert the entire patch for now since it is not very clear why
> stopping the kthreads breaks the firmware.
>
> [1]: https://lore.kernel.org/linux-staging/CAPY8ntBaz_RGr2sboQqbuUv+xZNfRct6-sckDLYPTig_HWyXEw@mail.gmail.com/t/#me90b9a9bc91599f18cd65ceb7eedd40e5fee0cdd
>
> [2]: https://lore.kernel.org/linux-staging/171161507013.3072637.12125782507523919379@ping.linuxembedded.co.uk/T/#m1d3de7d2fa73b2447274858353bbd4a0c3a8ba14
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
prev parent reply other threads:[~2024-04-05 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 5:21 [PATCH v2] Revert "staging: vc04_services: vchiq_core: Stop kthreads on shutdown" Umang Jain
2024-04-05 10:24 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34b14772-1386-44f4-bb7e-e3f6cf137971@gmx.net \
--to=wahrenst@gmx.net \
--cc=broonie@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=greg@kroah.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).