From: Dan Carpenter <dan.carpenter@linaro.org>
To: Prasad Pandit <ppandit@redhat.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
rjui@broadcom.com, sbranden@broadcom.com,
linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Prasad Pandit <pjp@fedoraproject.org>
Subject: Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg
Date: Wed, 13 Mar 2024 14:53:47 +0300 [thread overview]
Message-ID: <3fcb3702-5af2-4b9f-a362-4f08ee626b14@moroto.mountain> (raw)
In-Reply-To: <CAE8KmOzcD+__7xdC7tegbHO9HEP48s7=reA4j-tvqVDwzHr+8Q@mail.gmail.com>
On Wed, Mar 13, 2024 at 04:44:09PM +0530, Prasad Pandit wrote:
> Hi,
>
> On Wed, 13 Mar 2024 at 15:47, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> > Why does this make a difference? Is it just because it's annoying to
> > cat a file that doesn't have a newline at the end?
>
> * It's not just #PetPeeve. I'm trying to fix parsing errors reported
> by the config-kernel tool[1], so that users can view all CONFIG
> attributes without errors.
Huh. The seems like a very nice program. I've wanted a way to enable
config items from command line for a long time. I wasn't able to get it
enable the CONFIG_NO_HZ_FULL.
~/config-kernel/configk -e NO_HZ_FULL -c .config .
I'm going Ack your patch because adding a newline is the correct thing
but you should probably also change configk to handle that.
>
> > I checked, and it's not a checkpatch warning. Perhaps it should be though.
> > KTODO: make checkpatch.pl warn about files that don't end in a newline
>
> * I'll take a look at checkpatch.pl.
It's not required. The KTODO is just a shared todo list and anyone can
add stuff to todo list or do it, but it's not mandatory at all.
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-13 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 9:12 [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg Prasad Pandit
2024-03-13 10:17 ` Dan Carpenter
2024-03-13 11:14 ` Prasad Pandit
2024-03-13 11:53 ` Dan Carpenter [this message]
2024-03-13 16:49 ` Prasad Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fcb3702-5af2-4b9f-a362-4f08ee626b14@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).