From: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>
To: Ayush Tiwari <ayushtiw0110@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH v2 0/3] Trivial code cleanup patches
Date: Wed, 20 Mar 2024 20:50:40 +0100 [thread overview]
Message-ID: <4105521.oiGErgHkdL@fdefranc-mobl3> (raw)
In-Reply-To: <6485785.DvuYhMxLoT@fdefranc-mobl3>
On Tuesday, 19 March 2024 07:04:34 CET Fabio M. De Francesco wrote:
> On Monday, 18 March 2024 20:54:09 CET Ayush Tiwari wrote:
> > Address different kinds of checkpatch complains for the rtl8712 module
> > to ensure adherence to coding style guidelines.
> >
> > Changes in v2: Checked any possible reuse of backup_PMKID_list
> > manually and rebuilt,
No you didn't do what you are saying.
> rebooted the kernel and loaded the driver
> > with modprobe.
>
> You have not made any changes to any of the three patches in this series.
> No changes in commit messages and no changes in code. Am I missing
> something?
>
> So why did you submit a v2 of this series?
>
> Fabio
Julia commented on patch 1/3. You should either reply that everything is
correct (if it is) or fix your patch. Please don't send new versions that
don't change anything and don't ignore comments (mine included).
> > Ayush Tiwari (3):
> > staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
This patch introduces errors. You haven't compiled this module, otherwise
you would have noticed that. Always compile your changes (preferably with
CONFIG_WERROR set).
Please read the output of git-grep:
[fabio@linux]$ git grep backupPMKIDList drivers/staging/rtl8712
drivers/staging/rtl8712/mlme_linux.c: static struct RT_PMKID_LIST
backupPMKIDList[NUM_PMKID_CACHE];
drivers/staging/rtl8712/mlme_linux.c: memcpy(&backupPMKIDList[0],
drivers/staging/rtl8712/mlme_linux.c: &backupPMKIDList[0],
Can you see how patch 1/3 introduces errors?
Fabio
> > staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
> > staging: rtl8712: rename backupTKIPCountermeasure to
> >
> > backup_TKIP_countermeasure
> >
> > drivers/staging/rtl8712/mlme_linux.c | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
prev parent reply other threads:[~2024-03-20 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 19:24 [PATCH 0/3] Trivial code cleanup patches Ayush Tiwari
2024-03-17 19:26 ` [PATCH 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list Ayush Tiwari
2024-03-18 7:39 ` Julia Lawall
2024-03-18 19:55 ` [PATCH v2 " Ayush Tiwari
2024-03-17 19:26 ` [PATCH 2/3] staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index Ayush Tiwari
2024-03-18 19:57 ` [PATCH v2 " Ayush Tiwari
2024-03-17 19:27 ` [PATCH 3/3] staging: rtl8712: rename backupTKIPCountermeasure to backup_TKIP_countermeasure Ayush Tiwari
2024-03-18 19:58 ` [PATCH v2 " Ayush Tiwari
2024-03-18 19:54 ` [PATCH v2 0/3] Trivial code cleanup patches Ayush Tiwari
2024-03-19 6:04 ` Fabio M. De Francesco
2024-03-20 19:50 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4105521.oiGErgHkdL@fdefranc-mobl3 \
--to=fabio.maria.de.francesco@linux.intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=ayushtiw0110@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).