From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Chen shuo <1289151713@qq.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:rtl8192e:fixes unnecessary braces
Date: Tue, 7 May 2024 19:49:06 +0200 [thread overview]
Message-ID: <42016d13-b69c-400a-98a6-f34db6dd3e06@gmail.com> (raw)
In-Reply-To: <tencent_1423E8EA63C9C00B49636738FF1050480C06@qq.com>
On 5/7/24 14:13, Chen shuo wrote:
> This patch fixes the warnings reported by checkpatch.pl
> for braces {} are not necessary for single statement blocks
>
> Signed-off-by: Chen shuo <1289151713@qq.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index e3ed709a7674..1862a9899966 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1640,9 +1640,8 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
> if (stats->Length < 24)
> stats->bHwError |= 1;
>
> - if (stats->bHwError) {
> + if (stats->bHwError)
> return false;
> - }
>
> stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
> stats->RxBufShift = (pdesc->Shift) & 0x03;
Hi Chen,
Please make your "Subject" line more unique. Consider that we may end up
with having dozen of commits like yours, all of them referring to
different removals and all without the necessary information to tell
what they differ in (except the driver/subsystem). So it would help if
you add the changed file or function to make it more unique.
Also typically we use space after : and driver name in the subject.
It is not required to add the name of the tool who found this. Much more
important is a good description __why__ this change makes sense...
For example:
... to shorten code.
... to improve readability.
If you send in a second version of this patch please use a change
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Feel free to contact me direct for further questions.
Thanks for your support.
Bye Philipp
prev parent reply other threads:[~2024-05-07 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 12:13 [PATCH] staging:rtl8192e:fixes unnecessary braces Chen shuo
2024-05-07 17:49 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42016d13-b69c-400a-98a6-f34db6dd3e06@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=1289151713@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).