From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FEC770 for ; Wed, 19 May 2021 20:06:44 +0000 (UTC) Received: by mail-il1-f176.google.com with SMTP id h6so13274503ila.7 for ; Wed, 19 May 2021 13:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yZeOnuZeT/FAFpEU8iKvZOWrDJSy1lQIQkosiknz+tw=; b=B4L4Cf4ob7jI8O9tCpuGsSoGTTsYT8cNP5C9LiGilDHx9PkhpMToY9/1ewEkYXeKHj W3jdPK68fcLfLZGyadnqvj01SLWr2Eb73VBvpyJD+DHI0LHr0rY0JI/7Vea++hnf8wA2 tn6oQnUx4SLKT/CFbkcyjDyq5A/I/Rs1GTu4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yZeOnuZeT/FAFpEU8iKvZOWrDJSy1lQIQkosiknz+tw=; b=W/S14Y/TAXbAPKIj5iRdNvx0YnNDFCrEZ8HhXxcatwfvScRLZAG6I+eXMkFegd+5X5 zFnkt7Nn7OAOHvPxy0saM+pnmUv9p9iDwIXMq2pCrcZgY8dNhDR5evC0Pfs/Hhn4yfyV g70oMFTTeleCN/ynGqYtW9Ggz+p8Xo6xkYQ90EezYSHStm3yCrpbuJqma5z2ZaPveGNz z7v3mw/decxnLGbetd7yXJPlZEcppkCkM5p0mqc1JRcZg5nKpbsIv1FSYw7uzH8qOmiz TMIKtOwMASVYkYvZD04G3OEzbt0jTePwf+1A1gsFK6fiXZh9RuRNklo3CldLI7jzBYx9 47bA== X-Gm-Message-State: AOAM530i5IG12rYZDiMwebhVVPuVvauWNoOMAiGYq8Am+0vFVoKDaBeo 4MXTKdPvpex0jVVOfs/hTcve1Q== X-Google-Smtp-Source: ABdhPJyMEwvEgzqb8XIl+iED4/ZpznyOYcX85jjsq1lC52oKNgGcLJYBNbDvhDFAMFiGWRJzkYm2+w== X-Received: by 2002:a92:3f08:: with SMTP id m8mr884825ila.154.1621454803442; Wed, 19 May 2021 13:06:43 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id v2sm577049ioh.14.2021.05.19.13.06.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 13:06:42 -0700 (PDT) Subject: Re: [PATCH V2] Staging: greybus: fix open parenthesis error in gbphy.c To: "F.A.Sulaiman" , johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210519181938.30813-1-asha.16@itfac.mrt.ac.lk> From: Alex Elder Message-ID: <4af943f6-9baa-72a6-12b5-6b35179a7019@ieee.org> Date: Wed, 19 May 2021 15:06:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210519181938.30813-1-asha.16@itfac.mrt.ac.lk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/19/21 1:19 PM, F.A.Sulaiman wrote: > This patch fix "Alignment should match open parenthesis" checkpatch error. > > Signed-off-by: "F.A.Sulaiman" I have mixed feelings about this one. This alignment rule is fine, but I personally don't think it improves things. Aside from that, there are a few more places in the Greybus code that lead to exactly this warning. So I guess, if we're going to have the code follow this alignment rule, why not just fix all spots at once (i.e., in a patch series)? Anyway, I'll offer this, but perhaps others can provide their opinion. Acked-by: Alex Elder > --- > drivers/staging/greybus/gbphy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c > index 9fc5c47be9bd..13d319860da5 100644 > --- a/drivers/staging/greybus/gbphy.c > +++ b/drivers/staging/greybus/gbphy.c > @@ -27,7 +27,7 @@ struct gbphy_host { > static DEFINE_IDA(gbphy_id); > > static ssize_t protocol_id_show(struct device *dev, > - struct device_attribute *attr, char *buf) > + struct device_attribute *attr, char *buf) > { > struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); > > @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver) > EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver); > > static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle, > - struct greybus_descriptor_cport *cport_desc) > + struct greybus_descriptor_cport *cport_desc) > { > struct gbphy_device *gbphy_dev; > int retval; >