From: Dan Carpenter <dan.carpenter@linaro.org>
To: Shahar Avidar <ikobh7@gmail.com>
Cc: gregkh@linuxfoundation.org, elder@linaro.org,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
parthiban.veerasooran@microchip.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS.
Date: Mon, 25 Mar 2024 08:52:34 +0300 [thread overview]
Message-ID: <662306a0-1544-4f16-81cc-68324a0c3172@moroto.mountain> (raw)
In-Reply-To: <20240324093201.793485-3-ikobh7@gmail.com>
On Sun, Mar 24, 2024 at 11:32:00AM +0200, Shahar Avidar wrote:
> The driver can't actually support 2^20 devices.
> Current RasPis GPIO pins can actually support only 1 device.
> Other or future platforms might support more.
>
Why are you doing this? Is it just a clean up or does it have some
effect on runtime? And if it does have an effect on runtime, what does
that look like to the user? This all needs to be in the commit message.
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-25 5:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 9:31 [PATCH 0/3] staging: pi433: Fix includes & macros Shahar Avidar
2024-03-24 9:31 ` [PATCH 1/3] staging: pi433: Use headers in appropriate files Shahar Avidar
2024-03-24 9:32 ` [PATCH 2/3] staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS Shahar Avidar
2024-03-25 5:52 ` Dan Carpenter [this message]
2024-03-24 9:32 ` [PATCH 3/3] staging: pi433: Make use of spi mode macro instead of magic number Shahar Avidar
2024-03-25 9:18 ` [PATCH 0/3] staging: pi433: Fix includes & macros Andy Shevchenko
2024-03-25 18:05 ` Greg KH
2024-03-25 18:41 ` Andy Shevchenko
2024-03-25 18:51 ` Greg KH
2024-03-25 19:12 ` Andy Shevchenko
2024-03-26 6:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=662306a0-1544-4f16-81cc-68324a0c3172@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ikobh7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).