From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH v2 1/8] Staging: sm750fb: Rename variable sii164GetDeviceID
Date: Thu, 7 Mar 2024 15:43:10 +0300 [thread overview]
Message-ID: <82eda60e-5188-4a3e-8939-13a24d661579@moroto.mountain> (raw)
In-Reply-To: <20240306043611.98074-2-dorine.a.tipo@gmail.com>
On Wed, Mar 06, 2024 at 04:36:04AM +0000, Dorine Tipo wrote:
> Rename variable sii164GetDeviceID to sii164_get_device_id to silence
> checkpatch warning Avoid CamelCase
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> V2: Added the patch to a series.
> Fixed erroers within the patch.
> Compiled the kernel
>
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index 8b81e8642f9e..3fb14eff2de1 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
> {
> .init = sii164_init_chip,
> .get_vendor_id = sii164_get_vendor_id,
> - .get_device_id = sii164GetDeviceID,
> + .get_device_id = sii164_get_device_id,
You have to compile the kernel after every patch. Like apply *just*
this patch, then rebuild. It breaks.
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-07 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 4:36 [PATCH v2 0/8] Rename Variables in sm750fb driver Dorine Tipo
2024-03-06 4:36 ` [PATCH v2 1/8] Staging: sm750fb: Rename variable sii164GetDeviceID Dorine Tipo
2024-03-07 12:43 ` Dan Carpenter [this message]
2024-03-06 4:36 ` [PATCH v2 2/8] Staging: sm750fb: Rename sii164ResetChip Dorine Tipo
2024-03-06 4:36 ` [PATCH v2 3/8] Staging: sm750fb: Rename variable sii164GetChipString Dorine Tipo
2024-03-06 4:36 ` [PATCH v2 4/8] Staging: sm750fb: Rename variable sii164SetPower Dorine Tipo
2024-03-06 4:36 ` [PATCH v2 5/8] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection Dorine Tipo
2024-03-06 4:36 ` [PATCH v2 6/8] Staging: sm750fb: Rename variable sii164IsConnected Dorine Tipo
2024-03-06 4:36 ` [PATCH v2 7/8] Staging: sm750fb: Rename variable sii164CheckInterrupt Dorine Tipo
2024-03-06 4:36 ` [PATCH v2 8/8] Staging: sm750fb: Rename Variable sii164ClearInterrupt Dorine Tipo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82eda60e-5188-4a3e-8939-13a24d661579@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).