From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ayush Tiwari <ayushtiw0110@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8712: Rename blnPending to bln_pending
Date: Tue, 19 Mar 2024 09:33:08 +0300 [thread overview]
Message-ID: <865b37f4-8139-4072-a320-855bfc3121f4@moroto.mountain> (raw)
In-Reply-To: <Zfiz7YFKAqAOGsu5@ayush-HP-Pavilion-Gaming-Laptop-15-ec0xxx>
On Tue, Mar 19, 2024 at 03:06:45AM +0530, Ayush Tiwari wrote:
> Rename blnPending to bln_pending in r8712_cmd_thread() to address
> checkpatch warning "Avoid Camelcase" and conform to the kernel coding
> style.
>
> Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
> ---
What does bln_ mean? I suspect that b means byte and we don't allow
that sort of naming scheme. But I don't know what ln means. Also the
type should be bool and we change 1/0 to true/false.
regards,
dan carpenter
prev parent reply other threads:[~2024-03-19 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 21:36 [PATCH] staging: rtl8712: Rename blnPending to bln_pending Ayush Tiwari
2024-03-19 6:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865b37f4-8139-4072-a320-855bfc3121f4@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=Larry.Finger@lwfinger.net \
--cc=ayushtiw0110@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).