From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Felix N. Kimbu" <felixkimbu1@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check
Date: Tue, 12 Mar 2024 12:03:09 +0300 [thread overview]
Message-ID: <9bffd12a-afae-45cd-a4f3-451872146bf3@moroto.mountain> (raw)
In-Reply-To: <Ze9Ie67PCSvBU+og@MOLeToid>
On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote:
> @@ -185,14 +185,14 @@ int skb_ether_to_p80211(struct wlandevice *wlandev, u32 ethconv,
> p80211_wep->data = kmalloc(skb->len, GFP_ATOMIC);
> if (!p80211_wep->data)
> return -ENOMEM;
> - foo = wep_encrypt(wlandev, skb->data, p80211_wep->data,
> - skb->len,
> - wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK,
> - p80211_wep->iv, p80211_wep->icv);
> - if (foo) {
> + decrypt_check = wep_encrypt(wlandev, skb->data, p80211_wep->data,
> + skb->len,
> + wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK,
> + p80211_wep->iv, p80211_wep->icv);
With the rename the indenting did need to be updated, yes. However it
should have been:
decrypt_check = wep_encrypt(wlandev, skb->data, p80211_wep->data,
skb->len,
wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK,
p80211_wep->iv, p80211_wep->icv);
[tab][tab][tab][tab][tab][space][space][space][space]skb->len,
See my blog for how to resend a patch:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-12 9:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 18:07 [PATCH] staging: p80211conv: Rename local foo to decrypt_check Felix N. Kimbu
2024-03-11 19:31 ` Philipp Hortmann
2024-03-11 21:34 ` [PATCH v2] staging: wlan-ng: p80211conv: fix indentation problems, introduced by previous commit Felix N. Kimbu
2024-03-11 22:52 ` Alison Schofield
2024-03-12 14:19 ` Felix Kimbu
2024-03-11 22:46 ` [PATCH] staging: p80211conv: Rename local foo to decrypt_check Alison Schofield
2024-03-12 9:01 ` Dan Carpenter
2024-03-12 14:09 ` Felix Kimbu
2024-03-12 9:03 ` Dan Carpenter [this message]
2024-03-12 14:16 ` Felix Kimbu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bffd12a-afae-45cd-a4f3-451872146bf3@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=felixkimbu1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).