From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>, Kate Hsuan <hpa@redhat.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
Yury Luneff <yury.lunev@gmail.com>,
Nable <nable.maininbox@googlemail.com>,
andrey.i.trufanov@gmail.com,
Fabio Aiuto <fabioaiuto83@gmail.com>,
Dan Scally <djrscally@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/5] media: atomisp: Add support for v4l2-async sensor registration
Date: Sat, 27 May 2023 13:26:02 +0300 [thread overview]
Message-ID: <CAHp75Vf9SsjYAH+jBhMQ4+MOvrs4zB1HZEWjK4XK5vGKV+39Xw@mail.gmail.com> (raw)
In-Reply-To: <c53ec167-9211-9d27-db06-f4b2db5f258d@redhat.com>
On Sat, May 27, 2023 at 12:25 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 5/26/23 22:30, Andy Shevchenko wrote:
> > On Thu, May 25, 2023 at 10:01 PM Hans de Goede <hdegoede@redhat.com> wrote:
...
> > Besides that since we have a handle, wouldn't it be better to use
> > acpi_handle_info() here?
>
> Yes since we are purely dealing with ACPI / fwnode stuff here using
> that would make more sense. I'll switch to that.
>
> I also agree with all your other remarks and I'll fix them all up
> (and test things again) before merging.
>
> Andy, may I add your Reviewed-by to this patch too after fixing
> up all your remarks ?
Sure, go ahead!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-27 10:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 19:00 [PATCH v2 0/5] media: atomisp: Add support for v4l2-async sensor registration Hans de Goede
2023-05-25 19:00 ` [PATCH v2 1/5] " Hans de Goede
2023-05-26 20:30 ` Andy Shevchenko
2023-05-27 9:25 ` Hans de Goede
2023-05-27 10:26 ` Andy Shevchenko [this message]
2023-05-25 19:00 ` [PATCH v2 2/5] media: atomisp: ov2680: Turn into standard v4l2 sensor driver Hans de Goede
2023-07-05 13:34 ` Sakari Ailus
2023-05-25 19:00 ` [PATCH v2 3/5] media: atomisp: gc0310: " Hans de Goede
2023-07-05 13:45 ` Sakari Ailus
2023-07-06 6:37 ` Jacopo Mondi
2023-07-06 6:43 ` Sakari Ailus
2023-07-06 7:17 ` Jacopo Mondi
2023-07-06 7:20 ` Sakari Ailus
2023-05-25 19:00 ` [PATCH v2 4/5] media: atomisp: Drop v4l2_get_acpi_sensor_info() function Hans de Goede
2023-05-25 19:01 ` [PATCH v2 5/5] media: Move gc0310 sensor drivers to drivers/media/i2c/ Hans de Goede
2023-05-26 21:23 ` [PATCH v2 0/5] media: atomisp: Add support for v4l2-async sensor registration Andy Shevchenko
2023-05-27 15:54 ` Hans de Goede
2024-04-30 10:32 ` Mauro Carvalho Chehab
2024-04-30 11:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf9SsjYAH+jBhMQ4+MOvrs4zB1HZEWjK4XK5vGKV+39Xw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrey.i.trufanov@gmail.com \
--cc=andy@kernel.org \
--cc=djrscally@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nable.maininbox@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yury.lunev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).