From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jack Zhu" <jack.zhu@starfivetech.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: 回复: [PATCH] media: staging: media: starfive: camss: Convert to platform remove callback returning void
Date: Fri, 8 Mar 2024 09:11:48 +0000 [thread overview]
Message-ID: <SHXPR01MB06719D8714C431388BCCF1DFF227A@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn> (raw)
In-Reply-To: <c43a9c68e64e3e8360174ae0c6706e46d3d40a11.1709886922.git.u.kleine-koenig@pengutronix.de>
Hi, Uwe
Thanks for your patch.
> [PATCH] media: staging: media: starfive: camss: Convert to platform
> remove callback returning void
>
> The .remove() callback for a platform driver returns an int which makes many
> driver authors wrongly assume it's possible to do error handling by returning
> an error code. However the value returned is ignored (apart from emitting a
> warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return void. In
> the first step of this quest all drivers are converted to .remove_new(), which
> already returns void. Eventually after all drivers are converted, .remove_new()
> will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove callback
> to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/staging/media/starfive/camss/stf-camss.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/starfive/camss/stf-camss.c
> b/drivers/staging/media/starfive/camss/stf-camss.c
> index a587f860101a..f9613c2c9dfe 100644
> --- a/drivers/staging/media/starfive/camss/stf-camss.c
> +++ b/drivers/staging/media/starfive/camss/stf-camss.c
> @@ -355,7 +355,7 @@ static int stfcamss_probe(struct platform_device
> *pdev)
> *
> * Always returns 0.
The annotation from here can be removed.
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Regards,
Changhuang
prev parent reply other threads:[~2024-03-08 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:51 [PATCH] media: staging: media: starfive: camss: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-08 9:11 ` Changhuang Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SHXPR01MB06719D8714C431388BCCF1DFF227A@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn \
--to=changhuang.liang@starfivetech.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).