From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase
Date: Wed, 7 Apr 2021 19:27:38 +0200 [thread overview]
Message-ID: <YG3rihKrS2tvr1tS@kroah.com> (raw)
In-Reply-To: <20210407163000.27611-1-fmdefrancesco@gmail.com>
On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote:
> Remove camelcase. Issue detected by checkpatch.pl. For now, change only
> names of static functions in order to not break the driver's code.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 44 ++++++++++++------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index b1f02bb9f0a9..5e28818e58e0 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -19,7 +19,7 @@
> /* */
> /* Creadted by Roger, 2011.01.31. */
> /* */
> -static void HalSdioGetCmdAddr8723BSdio(
> +static void hal_sdio_get_cmd_addr_8723b_sdio(
> struct adapter *adapter,
> u8 device_id,
> u32 addr,
> @@ -97,7 +97,7 @@ static u8 get_deviceid(u32 addr)
>
> /*
> * Ref:
> - *HalSdioGetCmdAddr8723BSdio()
> + *hal_sdio_get_cmd_addr_8723b_sdio()
What does this comment even mean?
I think you can delete it.
But really, that's a crazy function name length, can you make it any
shorter?
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-07 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 16:30 [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase Fabio M. De Francesco
2021-04-07 17:27 ` Greg KH [this message]
2021-04-07 17:51 ` Fabio M. De Francesco
-- strict thread matches above, loose matches on Subject: below --
2021-04-12 21:02 Fabio M. De Francesco
2021-04-12 21:05 ` Julia Lawall
2021-04-12 21:13 ` Matthew Wilcox
2021-04-13 7:39 ` Greg Kroah-Hartman
2021-04-13 9:12 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG3rihKrS2tvr1tS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).