From: Greg KH <gregkh@linuxfoundation.org>
To: Luo Meng <luomeng12@huawei.com>
Cc: nathan@kernel.org, ndesaulniers@google.com,
fabioaiuto83@gmail.com, ross.schm.dev@gmail.com,
marcocesati@gmail.com, matthew.v.deangelis@gmail.com,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove unused variable
Date: Wed, 19 May 2021 17:49:03 +0200 [thread overview]
Message-ID: <YKUzb7vI2puZzBaa@kroah.com> (raw)
In-Reply-To: <20210515082150.165660-1-luomeng12@huawei.com>
On Sat, May 15, 2021 at 04:21:50PM +0800, Luo Meng wrote:
> Fix the following clang warning:
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c:2356:6:
> warning: variable ‘pframe’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Luo Meng <luomeng12@huawei.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 4707dba90397..c2bbb66666b0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -2353,12 +2353,11 @@ void rtw_build_wmm_ie_ht(struct adapter *padapter, u8 *out_ie, uint *pout_len)
> {
> unsigned char WMM_IE[] = {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01, 0x00};
> int out_len;
> - u8 *pframe;
>
> if (padapter->mlmepriv.qospriv.qos_option == 0) {
> out_len = *pout_len;
> - pframe = rtw_set_ie(out_ie+out_len, WLAN_EID_VENDOR_SPECIFIC,
> - _WMM_IE_Length_, WMM_IE, pout_len);
> + rtw_set_ie(out_ie+out_len, WLAN_EID_VENDOR_SPECIFIC,
> + WMM_IE_Length_, WMM_IE, pout_len);
>
> padapter->mlmepriv.qospriv.qos_option = 1;
> }
> --
> 2.25.4
>
>
Does not apply to my tree :(
next prev parent reply other threads:[~2021-05-19 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 8:21 [PATCH] staging: rtl8723bs: remove unused variable Luo Meng
2021-05-19 15:49 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-07 3:18 Jiapeng Chong
2021-04-07 8:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKUzb7vI2puZzBaa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fabioaiuto83@gmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=luomeng12@huawei.com \
--cc=marcocesati@gmail.com \
--cc=matthew.v.deangelis@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ross.schm.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).