From: Alison Schofield <alison.schofield@intel.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, pure.logic@nexus-software.ie,
johan@kernel.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: Add blank line after struct declaration
Date: Mon, 11 Mar 2024 16:04:56 -0700 [thread overview]
Message-ID: <Ze+OGOEcpbrl7HJL@aschofie-mobl2> (raw)
In-Reply-To: <20240310053718.6435-1-dorine.a.tipo@gmail.com>
On Sun, Mar 10, 2024 at 05:37:18AM +0000, Dorine Tipo wrote:
> Add a blank line after the loopback_class struct declaration to silence
> checkpatch warning Please use a blank line after
Hi Dorine,
I think you have a few patches posted where using a similar
phrase '...to silence checkpatch warning'.
The phrase is awkward because we never have a goal of silencing
any warnings. We 'address' them. This checkpatch warning is
reporting something that does not adhere to the kernel coding
style. So, more fitting to say - "...to adhere to the kernel
coding style." Adding 'Issue found using checkpatch' or
the actual checkpatch warnging is commonly added.
When you are addressing checkpatch warnings, you can bet you
are not the first one to address it. So, you can search on
previous commit messages and see what was well received, and
if you search on Lore history, you can also see what was not
well received. The Outreachy mailing list is a treasure trove
of checkpatch commits.
This, linked in the First Patch Tutorial, is helpful -
https://kernelnewbies.org/PatchPhilosophy
- Alison
> function/struct/union/enum declarations.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index bb33379b5297..4313d3bbc23a 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -101,6 +101,7 @@ struct gb_loopback {
> static struct class loopback_class = {
> .name = "gb_loopback",
> };
> +
> static DEFINE_IDA(loopback_ida);
>
> /* Min/max values in jiffies */
> --
> 2.25.1
>
>
prev parent reply other threads:[~2024-03-11 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 5:37 [PATCH] staging: greybus: Add blank line after struct declaration Dorine Tipo
2024-03-10 10:47 ` [PATCH v2] " Dorine Tipo
2024-03-10 11:41 ` Julia Lawall
2024-03-11 23:04 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze+OGOEcpbrl7HJL@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).