From: Alison Schofield <alison.schofield@intel.com>
To: TaheraFahimi <fahimitahera@gmail.com>
Cc: Marc Dietrich <marvin24@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: nvec: edit udelay comment
Date: Wed, 20 Mar 2024 12:17:38 -0700 [thread overview]
Message-ID: <Zfs2Ug5INYKKyiDH@aschofie-mobl2> (raw)
In-Reply-To: <ZfS+UaVyob+lFmmS@tahera-OptiPlex-5000>
On Fri, Mar 15, 2024 at 03:32:01PM -0600, TaheraFahimi wrote:
> Signed-off-by: TaheraFahimi <fahimitahera@gmail.com>
Missing commit log.
Commit message would be clearer like: "correct a misspelled comment"
because when you say you are editing a udelay comment, it made me
think you were clarifying something about usage of udelay.
There are plenty of patches on this list with examples of how
patches of spelling corrections are worded in both the commit
message and log. Please take a look.
Thanks,
Alison
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 282a664c9176..b4485b10beb8 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -712,7 +712,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> * TODO: replace the udelay with a read back after each writel above
> * in order to work around a hardware issue, see i2c-tegra.c
> *
> - * Unfortunately, this change causes an intialisation issue with the
> + * Unfortunately, this change causes an initialisation issue with the
> * touchpad, which needs to be fixed first.
> */
> udelay(100);
> --
> 2.34.1
>
>
prev parent reply other threads:[~2024-03-20 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 21:32 [PATCH] staging: nvec: edit udelay comment TaheraFahimi
2024-03-20 19:17 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfs2Ug5INYKKyiDH@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=ac100@lists.launchpad.net \
--cc=fahimitahera@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).