* [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis
@ 2024-03-28 22:26 TaheraFahimi
2024-03-28 22:51 ` Alison Schofield
2024-04-02 6:49 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: TaheraFahimi @ 2024-03-28 22:26 UTC (permalink / raw
To: Greg Kroah-Hartman, linux-staging, linux-kernel, outreachy
Mute the following checkpatch error:
CHECK: Alignment should match open parenthesis
Signed-off-by: Tahera Fahimi <fahimitahera@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 15c246d3b1a3..bd80cd48fb44 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
int ret;
for (i = 0; i < TTY_MAX_COUNT; i++) {
- tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
- TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
+ tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
+ TTY_DRIVER_DYNAMIC_DEV);
if (IS_ERR(tty_driver))
return PTR_ERR(tty_driver);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis
2024-03-28 22:26 [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis TaheraFahimi
@ 2024-03-28 22:51 ` Alison Schofield
2024-04-02 6:49 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Alison Schofield @ 2024-03-28 22:51 UTC (permalink / raw
To: TaheraFahimi; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel, outreachy
On Thu, Mar 28, 2024 at 04:26:47PM -0600, TaheraFahimi wrote:
> Mute the following checkpatch error:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Tahera Fahimi <fahimitahera@gmail.com>
Tahera,
I'm seeing this from checkpatch:
WARNING: From:/Signed-off-by: email name mismatch: 'From: TaheraFahimi <fahimitahera@gmail.com>' != 'Signed-off-by: Tahera Fahimi <fahimitahera@gmail.com>'
Folks sometimes miss checkpatch reports if they only run checkpatch
on their head commit. Please run it on the formatted patch before
sending it.
Please refer to checkpatch documentation, but if it's useful, here's
what I do:
While developing a patch do this:
$ git show HEAD | scripts/checkpatch.pl --strict --codespell
Confirm with this before sending a patch to a mailing list:
$ scripts/checkpatch.pl --no-tree --strict --codespell $1
($1 is the formatted patch and that location is usually out of tree
in my development environment.)
--Alison
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 15c246d3b1a3..bd80cd48fb44 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
> if (IS_ERR(tty_driver))
> return PTR_ERR(tty_driver);
>
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis
2024-03-28 22:26 [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis TaheraFahimi
2024-03-28 22:51 ` Alison Schofield
@ 2024-04-02 6:49 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-04-02 6:49 UTC (permalink / raw
To: TaheraFahimi; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel, outreachy
On Thu, Mar 28, 2024 at 04:26:47PM -0600, TaheraFahimi wrote:
> Mute the following checkpatch error:
> CHECK: Alignment should match open parenthesis
It's not aligned either before or after. It should have been:
[tab][tab][tab][tab][tab][space][space][space][space][space][space]TTY_DRIVER_...
>
> Signed-off-by: Tahera Fahimi <fahimitahera@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 15c246d3b1a3..bd80cd48fb44 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -272,8 +272,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
"TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV" goes together. Don't
split that up over two lines. Checkpatch is a tool which is supposed to
help readability. It's not a ruler which must be obeyed. If checkpatch
tells you to do something which makes the code less readable then just
ignore it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-02 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-28 22:26 [PATCH] staging: gdm724x: Align descendant argument to the open parenthesis TaheraFahimi
2024-03-28 22:51 ` Alison Schofield
2024-04-02 6:49 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).