From: Bagas Sanjaya <bagasdotme@gmail.com>
To: me@wantyapps.xyz
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Prathu Baronia" <prathubaronia2011@gmail.com>,
"Rob Herring" <robh@kernel.org>, "Yangtao Li" <frank.li@vivo.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Khadija Kamran" <kamrankhadijadj@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: Fix indentation
Date: Mon, 1 Apr 2024 19:26:26 +0700 [thread overview]
Message-ID: <Zgqn8izgsMI7rQNA@archie.me> (raw)
In-Reply-To: <20240305211416.755911-1-me@wantyapps.xyz>
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
On Tue, Mar 05, 2024 at 11:14:01PM +0200, me@wantyapps.xyz wrote:
> From: Uri Arev <me@wantyapps.xyz>
>
> Warning reported by checkpatch.pl script:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Uri Arev <me@wantyapps.xyz>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 727b956aa231..ab758a527261 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> - read_timeout);
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + read_timeout);
>
> if (ret <= 0) {
> if (ret == 0) {
> @@ -522,9 +522,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> */
> mutex_lock(&fifo->write_lock);
> ret = wait_event_interruptible_timeout(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> - >= words_to_write,
> - write_timeout);
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> + >= words_to_write,
> + write_timeout);
>
> if (ret <= 0) {
> if (ret == 0) {
LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-01 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 21:14 [PATCH] staging: axis-fifo: Fix indentation me
2024-03-31 19:05 ` Uri Arev
2024-04-01 12:26 ` Bagas Sanjaya [this message]
2024-04-01 15:36 ` Uri Arev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zgqn8izgsMI7rQNA@archie.me \
--to=bagasdotme@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=frank.li@vivo.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@wantyapps.xyz \
--cc=prathubaronia2011@gmail.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).