From: Dan Carpenter <dan.carpenter@linaro.org>
To: sumadhura kalyan <opensourcecond@gmail.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
gregkh@linuxfoundation.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents.
Date: Sun, 14 Apr 2024 15:01:14 +0300 [thread overview]
Message-ID: <a3c1d471-849b-4d4d-8657-4ad73493fca2@moroto.mountain> (raw)
In-Reply-To: <20240414115106.105946-1-opensourcecond@gmail.com>
The subject is too vague.
On Sun, Apr 14, 2024 at 05:21:06PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
^^^^^^^^^^^^^^^^^^^^^^^^^
What issue?
A better commit message would be:
==================
Subject: [PATCH v3] staging: vc04_services: re-align function parameters
Checkpatch complains that:
CHECK: Lines should not end with a '('
#45: FILE: drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h:45:
+typedef void (*vchiq_mmal_buffer_cb)(
Re-align the function parameters to make checkpatch happy.
================
>
> Signed-off-by: sumadhura kalyan <opensourcecond@gmail.com>
^ ^
You should make these capital letters... It's supposed to look formal
like you're signing a legal document.
regards,
dan carpenter
prev parent reply other threads:[~2024-04-14 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 11:51 [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents sumadhura kalyan
2024-04-14 12:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c1d471-849b-4d4d-8657-4ad73493fca2@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=opensourcecond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).