From: Julia Lawall <julia.lawall@inria.fr>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: vt6655: Fix line length exceeding 100 columns
Date: Sun, 10 Mar 2024 17:29:34 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2403101728560.51678@hadrien> (raw)
In-Reply-To: <20240310161407.3345-1-dorine.a.tipo@gmail.com>
On Sun, 10 Mar 2024, Dorine Tipo wrote:
> Break function declaration into multiple lines.
>
> This patch breaks the RFbAL7230SelectChannelPostProcess() function
> declaration into multiple lines to improve readability and compliance
> with coding standards.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/staging/vt6655/rf.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
> index 6f842ac00526..057860a5e100 100644
> --- a/drivers/staging/vt6655/rf.h
> +++ b/drivers/staging/vt6655/rf.h
> @@ -69,7 +69,8 @@ void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
> long *pldBm);
>
> /* {{ RobertYu: 20050104 */
> -bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
> +bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel,
> + u16 byNewChannel);
Maybe there is a way to make the name of the function shorter instead? It
looks pretty long y Linux kernel standards.
julia
> /* }} RobertYu */
>
> #endif /* __RF_H__ */
> --
> 2.25.1
>
>
>
prev parent reply other threads:[~2024-03-10 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 16:14 [PATCH] staging: vt6655: Fix line length exceeding 100 columns Dorine Tipo
2024-03-10 16:29 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2403101728560.51678@hadrien \
--to=julia.lawall@inria.fr \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).