From: Julia Lawall <julia.lawall@inria.fr>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: "Felix N. Kimbu" <felixkimbu1@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
Date: Mon, 11 Mar 2024 21:46:38 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2403112146230.3216@hadrien> (raw)
In-Reply-To: <5f6b7fad-5ad3-44a0-9e10-3e1c13109abd@gmail.com>
On Mon, 11 Mar 2024, Philipp Hortmann wrote:
> On 3/11/24 18:05, Julia Lawall wrote:
> >
> >
> > On Mon, 11 Mar 2024, Felix N. Kimbu wrote:
> >
> > > Remove unnecessary parentheses around 'wlandev->msdstate !=
> > > WLAN_MSD_RUNNING'
> > > in static int prism2_get_station(...)
> >
> > You don't need the name of the function in the subject line. That
> > information doesn't help understand the patch.
> >
> > julia
>
> Hi Julia,
>
> I think we do not need the function name in the subject but we need something
> to distinguish between the patches. The subject line needs to be a little
> unique. Otherwise we will have 100 patches like "[PATCH] staging: cfg80211:
> Remove parentheses" when we are unlucky. Any better proposal for a Subject
> uniqueness is welcome.
>
> Function name for this purpose is OK for me.
OK, no problem.
thanks,
julia
>
> Thanks for your support.
>
> Bye Philipp
>
>
> >
> > >
> > > This change ensures adherence to coding style guidelines.
> > >
> > > Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
> > > ---
> > > drivers/staging/wlan-ng/cfg80211.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/wlan-ng/cfg80211.c
> > > b/drivers/staging/wlan-ng/cfg80211.c
> > > index 471bb310176f..7451fd2bb580 100644
> > > --- a/drivers/staging/wlan-ng/cfg80211.c
> > > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > > @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy,
> > > struct net_device *dev,
> > >
> > > memset(sinfo, 0, sizeof(*sinfo));
> > >
> > > - if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> > > + if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
> > > return -EOPNOTSUPP;
> > >
> > > /* build request message */
> > > --
> > > 2.34.1
> > >
> > >
> > >
> >
>
>
prev parent reply other threads:[~2024-03-11 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 13:45 [PATCH] staging: cfg80211: Remove parentheses prism2_get_station Felix N. Kimbu
2024-03-11 14:09 ` Dan Carpenter
2024-03-11 17:05 ` Julia Lawall
2024-03-11 19:12 ` Philipp Hortmann
2024-03-11 20:46 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2403112146230.3216@hadrien \
--to=julia.lawall@inria.fr \
--cc=felixkimbu1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).