From: Julia Lawall <julia.lawall@inria.fr>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, forest@forestbond.com,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev,
julia.lawall@inria.fr, dan.carpenter@linaro.org
Subject: Re: [PATCH v7] staging: vt6655: Remove unused declaration of
Date: Sat, 16 Mar 2024 21:17:28 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2403162116580.3295@hadrien> (raw)
In-Reply-To: <20240316193016.1885-1-dorine.a.tipo@gmail.com>
On Sat, 16 Mar 2024, Dorine Tipo wrote:
> Remove unused function RFbAL7230SelectChannelPostProcess declared in
> rf.h but has no associated implementation.
>
> Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
> accidentally forgot to delete the declaration in the header file.
>
> Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> Changes since V1:
>
> V2: - Removed the unintended blank line after removing the dead code
> - Removed "in rf.h" from the subject
>
> V3: - Added in the Description Comment about unintended blank line
>
> V4: - Adjusted complete description according to hint from feedback
> - Rebased patch
> V5: - Added a missing closing parenthesis in the fixes tag
>
> V6: - Sent the wrong patch for v5. This version includes the fix in v5
>
> V7: - Made the subjectline more uniques as suggested by
> fabio.maria.de.francesco@linux.intel.com
Actually, this doesn't seem to have worked. The name of the function is
not included.
julia
>
> drivers/staging/vt6655/rf.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
> index 6f842ac00526..8eef100c7ef2 100644
> --- a/drivers/staging/vt6655/rf.h
> +++ b/drivers/staging/vt6655/rf.h
> @@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
> void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
> long *pldBm);
>
> -/* {{ RobertYu: 20050104 */
> -bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
> -/* }} RobertYu */
> -
> #endif /* __RF_H__ */
> --
> 2.25.1
>
>
prev parent reply other threads:[~2024-03-16 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 19:30 [PATCH v7] staging: vt6655: Remove unused declaration of Dorine Tipo
2024-03-16 20:17 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2403162116580.3295@hadrien \
--to=julia.lawall@inria.fr \
--cc=dan.carpenter@linaro.org \
--cc=dorine.a.tipo@gmail.com \
--cc=forest@forestbond.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).