From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] staging: vt6655: remove redundant assignment to variable byData
Date: Thu, 28 Mar 2024 22:44:40 +0100 [thread overview]
Message-ID: <b3b033ac-0fe7-4a89-a7f5-ee96d5c806d7@gmail.com> (raw)
In-Reply-To: <20240328111557.761380-1-colin.i.king@gmail.com>
On 3/28/24 12:15, Colin Ian King wrote:
> Variable byData is being assigned a value that is never read, it is
> being re-assigned later on. The assignment is redundant and can be
> removed.
>
> Cleans up clang scan build warning:
> drivers/staging/vt6655/srom.c:67:2: warning: Value stored to 'byData'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/staging/vt6655/srom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index 1b89d401a7eb..e80556509c58 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -64,7 +64,6 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
> unsigned char byData;
> unsigned char byOrg;
>
> - byData = 0xFF;
> byOrg = ioread8(iobase + MAC_REG_I2MCFG);
> /* turn off hardware retry for getting NACK */
> iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2024-03-28 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 11:15 [PATCH][next] staging: vt6655: remove redundant assignment to variable byData Colin Ian King
2024-03-28 21:44 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b033ac-0fe7-4a89-a7f5-ee96d5c806d7@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).