From: Dan Carpenter <dan.carpenter@linaro.org>
To: Sumadhura Kalyan <opensourcecond@gmail.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
gregkh@linuxfoundation.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] staging: vc04_services: Re-align function parameters
Date: Mon, 15 Apr 2024 09:02:38 +0300 [thread overview]
Message-ID: <bea0a328-a27b-46b2-8893-1943d0404a29@moroto.mountain> (raw)
In-Reply-To: <20240414144614.125672-1-opensourcecond@gmail.com>
On Sun, Apr 14, 2024 at 08:16:14PM +0530, Sumadhura Kalyan wrote:
> From: sumadhura kalyan <opensourcecond@gmail.com>
^^^^^^^^^^^^^^^^
This will mess things up.
>
> Checkpatch complains that:
>
> CHECK: Lines should not end with a '('
> +typedef void (*vchiq_mmal_buffer_cb)(
>
> Re-align the function parameters to make checkpatch happy.
>
> Signed-off-by: Sumadhura Kalyan <opensourcecond@gmail.com>
> ---
>
> v1 -> v2: Repharse the subject line.
Need more changelog here.
regards,
dan carpenter
prev parent reply other threads:[~2024-04-15 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 14:46 [PATCH V3] staging: vc04_services: Re-align function parameters Sumadhura Kalyan
2024-04-15 6:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bea0a328-a27b-46b2-8893-1943d0404a29@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=opensourcecond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).