From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AFCF71 for ; Tue, 13 Apr 2021 14:10:46 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id h4so7589506wrt.12 for ; Tue, 13 Apr 2021 07:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mkCkAJIkrOY7pAZ9reInsO74iKUOVHosiFJ4TLiQNQ8=; b=QT1oIyX+9iVDyxzz0ym6WeLK4T9wYQAhpg+JBOlR9g0kKFKVpAYzmLimy3RmQLgltJ j8hYH6IJtLVk2O3IogkWfpayVkA2iEo+4Z+QY4fiKRfugE4M1kt/m2+cXwACtFGO3EDu 4RNgPL5hcMHWNqBbdTyO0QwwL5php5FCwvC51gcfYmwGyySHQLutPC1RuxvF6Xbpyp8A 4RUfFMFai/EYV8I5v/IYd9hR7AKoTv5lDu4hZbz+SCnZpBoFYzAyIxqvQohrZgefAgKc k/PyTsRFGxvbYYaQuiBjmVE0mjIoGna4BKA4t+Q6veoDFNn+0zgXxh7lccX//YxFc/XO f1Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mkCkAJIkrOY7pAZ9reInsO74iKUOVHosiFJ4TLiQNQ8=; b=PX6nQeMEwruDmHdb/up5ah9xl7W2Ot2veJfo0P0uLXxaTI7M8JeyPv4rmpOqUESza3 B6PGjQL6Yn0iPHb9oHrUANgAzYK6aLpevS88mmHFhg/cRwWwU+pjunIExcy57klg2/Hf 0/pfFBLvFMzW0bjCYQ0jl7TRe+pCIT+THUw9JMWdyuLEVmFr+YQUG2AuQN8rMi1Gdaz5 fhJcNCB/HhmT6+UDhXBwAvOYMrjkjpDy7Zdo2O2z3wBsc3/Yqq48hZ4s6P9kHCcUeBlG LTW12wfgTp6NVnX17RCZKtSlkwTJiscbAKTWKa/JOnFXvyNqXcmgF2dQ4K8NQT7OR82g sk3A== X-Gm-Message-State: AOAM530L6TlWBoPoxMiuCR42OBrrUz6Tbjk4rEhW27gFGzaxr9eUX/kz kieDu3x5pMED0OSWVvv/K5k= X-Google-Smtp-Source: ABdhPJxbcd638a9JsO2Z9rbT4kJBz5lxLw+EtxwHOgcK+OPjnZc2vcw1U2EeKZtkggOIt5MNmTPruQ== X-Received: by 2002:adf:e0d1:: with SMTP id m17mr37060834wri.90.1618323044675; Tue, 13 Apr 2021 07:10:44 -0700 (PDT) Received: from agape ([5.171.81.171]) by smtp.gmail.com with ESMTPSA id 66sm3086598wmb.36.2021.04.13.07.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:10:44 -0700 (PDT) From: Fabio Aiuto To: Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg() Date: Tue, 13 Apr 2021 16:10:35 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patchset replaces DGB_871X_SEL_NL macro with the driver recommended log function netdev_dbg(). Macro DBG_871X_SEL_NL indeed executes a raw printk call as default behaviour. The other behaviour is doing a seq_printf() call which never occurs. First patch replace dump_drv_version with a netdev_dbg() call. Second patch remove an unnecessary dump_drv_version() usage. Third patch removes dump_drv_version() now unused and unused dump_log_level() as well Fourth patch apply the following coccinelle script for macro bulk replacement: @@ expression sel; expression list args; identifier padapter; identifier func; @@ func(..., struct adapter *padapter, ...) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(padapter->pnetdev, args); ...> } @rule@ identifier func, context, padapter; @@ func(void *context) { ... struct adapter *padapter = context; ... } @@ expression sel; expression list args; identifier rule.padapter; identifier rule.func, rule.context; @@ func(void *context) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(padapter->pnetdev, args); ...> } @@ expression sel; expression list args; expression get_dev; identifier func, dev; @@ func(...) { ... struct net_device *dev = get_dev; <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(dev, args); ...> } @@ expression sel; expression list args; identifier func, dev; @@ func(struct net_device *dev) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(dev, args); ...> } @@ expression sel; expression list args; identifier func, dvobj; @@ func(struct dvobj_priv *dvobj) { <... - DBG_871X_SEL_NL(sel, args); + netdev_dbg(dvobj->if1->pnetdev, args); ...> } Fifth patch fixes a post commit checkpatch issue left by coccinelle output. Sixth patch removes DBG_871X_SEL_NL macro declaration. Seventh patch removes an unused function argument after macro replacement. Fabio Aiuto (7): staging: rtl8723bs: replace dump_drv_version usage with netdev_* staging: rtl8723bs: remove unnecessary dump_drv_version() usage staging: rtl8723bs: remove two unused functions staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg() staging: rtl8723bs: put a new line after ';' staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration staging: rtl8723bs: remove unused argument in function drivers/staging/rtl8723bs/core/rtw_debug.c | 26 +++------- drivers/staging/rtl8723bs/core/rtw_odm.c | 52 ++++++++++--------- drivers/staging/rtl8723bs/hal/hal_com.c | 31 +++++------ drivers/staging/rtl8723bs/include/rtw_debug.h | 12 ----- drivers/staging/rtl8723bs/include/rtw_odm.h | 2 +- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 4 +- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 - 7 files changed, 51 insertions(+), 77 deletions(-) -- 2.20.1