From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: julia.lawall@inria.fr, joe@perches.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg()
Date: Wed, 14 Apr 2021 14:18:47 +0200 [thread overview]
Message-ID: <cover.1618401896.git.fabioaiuto83@gmail.com> (raw)
This patchset replaces DGB_871X_SEL_NL macro with the driver
recommended log function netdev_dbg().
Here are contained the patches not accepted yet in v1.
Macro DBG_871X_SEL_NL indeed executes a raw printk call as
default behaviour. The other behaviour is doing a seq_printf()
call which never occurs.
First patch apply the following coccinelle script for macro
bulk replacement:
@@
expression sel;
expression list args;
identifier padapter;
identifier func;
@@
func(..., struct adapter *padapter, ...) {
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(padapter->pnetdev, args);
...>
}
added by hand a newline in coccinelle output.
Second patch removes DBG_871X_SEL_NL macro declaration.
Third patch removes an unused function argument after
macro replacement.
-------------------------------------------------
Changes in v2:
- Excluded patches already accepted in v1
- Added by hand a newline after coccinelle script
application
- Dropped the patch applying newline separately
Fabio Aiuto (3):
staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()
staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration
staging: rtl8723bs: remove unused argument in function
drivers/staging/rtl8723bs/core/rtw_debug.c | 16 +++---
drivers/staging/rtl8723bs/core/rtw_odm.c | 52 ++++++++++---------
drivers/staging/rtl8723bs/hal/hal_com.c | 31 +++++------
drivers/staging/rtl8723bs/include/rtw_debug.h | 9 ----
drivers/staging/rtl8723bs/include/rtw_odm.h | 2 +-
.../staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
6 files changed, 50 insertions(+), 62 deletions(-)
--
2.20.1
next reply other threads:[~2021-04-14 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 12:18 Fabio Aiuto [this message]
2021-04-14 12:18 ` [PATCH v2 1/3] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg() Fabio Aiuto
2021-04-14 12:18 ` [PATCH v2 2/3] staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration Fabio Aiuto
2021-04-14 12:18 ` [PATCH v2 3/3] staging: rtl8723bs: remove unused argument in function Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1618401896.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).