From: Dan Carpenter <dan.carpenter@linaro.org>
To: pipishuo <1289151713@qq.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis
Date: Sun, 28 Apr 2024 16:59:48 +0300 [thread overview]
Message-ID: <e028e6a0-be04-4e1a-8932-c2fdcd7b7185@moroto.mountain> (raw)
In-Reply-To: <tencent_58C9EBCB7FA35A38EAD077080863D46A5D06@qq.com>
On Sun, Apr 28, 2024 at 08:04:34PM +0800, pipishuo wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
>
> Signed-off-by: pipishuo <1289151713@qq.com>
This is your legal name that you use to sign legal documents? Just one
word, all lower case?
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index c51818c56dd2..04f0e5b45a8b 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -376,7 +376,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> read_timeout);
Checkpatch is just a tool. It's supposed to make the code more
readable. Sometimes it makes mistakes and makes the code worse.
If it tells you to do something crazy then just ignore it.
regards,
dan carpenter
next prev parent reply other threads:[~2024-04-28 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 12:04 [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis pipishuo
2024-04-28 13:59 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-26 11:04 phanirajkiran
2024-01-04 13:32 ` Greg Kroah-Hartman
[not found] ` <CAJEOW9YiuBSLUrP0BkRGQRmJWOKpB4Y=DhTGUnDDumhuzmcH1A@mail.gmail.com>
2024-01-04 14:22 ` Greg Kroah-Hartman
2024-01-04 15:56 ` Phanirajkiran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e028e6a0-be04-4e1a-8932-c2fdcd7b7185@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=1289151713@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).