From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Jack Zhu <jack.zhu@starfivetech.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: 回复: [PATCH v2] media: staging: media: starfive: camss: Convert to platform remove callback returning void
Date: Fri, 12 Apr 2024 09:08:16 +0200 [thread overview]
Message-ID: <e5h2nqe6umpbzw3a7hhpdttmqr2w6kprwe7mavb4lj3cbmg2hk@k7xk6wgh5veh> (raw)
In-Reply-To: <SH0PR01MB066755DE4798EB2BD5EE04A9F204A@SH0PR01MB0667.CHNPR01.prod.partner.outlook.cn>
[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]
Hello,
On Fri, Apr 12, 2024 at 07:00:22AM +0000, Changhuang Liang wrote:
> > media: staging: media: starfive: camss: Convert to platform
> > remove callback returning void
> >
> > The .remove() callback for a platform driver returns an int which makes many
> > driver authors wrongly assume it's possible to do error handling by returning
> > an error code. However the value returned is ignored (apart from emitting a
> > warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return void. In
> > the first step of this quest all drivers are converted to .remove_new(), which
> > already returns void. Eventually after all drivers are converted, .remove_new()
> > will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove callback
> > to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>
> But it seems that v1 is already merge.
Hmm, it's not in next though. IMHO it would be a good idea to add the
tree that has my patch staged to next.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-04-12 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 7:28 [PATCH v2] media: staging: media: starfive: camss: Convert to platform remove callback returning void Uwe Kleine-König
2024-04-12 7:00 ` 回复: " Changhuang Liang
2024-04-12 7:08 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5h2nqe6umpbzw3a7hhpdttmqr2w6kprwe7mavb4lj3cbmg2hk@k7xk6wgh5veh \
--to=u.kleine-koenig@pengutronix.de \
--cc=changhuang.liang@starfivetech.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).