From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kamil Kasperski <ressetkk@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Maxime Ripard <mripard@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 3/3] arm64: dts: allwinner: h616: add support for T95 tv boxes
Date: Sun, 17 Mar 2024 18:49:53 +0100 [thread overview]
Message-ID: <f369871a-1cd5-4dd8-8b5f-2c6492e72b8b@linaro.org> (raw)
In-Reply-To: <f4f02cb2-6263-4bd4-a798-c92c31f7b363@gmail.com>
On 17/03/2024 16:36, Kamil Kasperski wrote:
> W dniu 17.03.2024 o 15:57, Krzysztof Kozlowski pisze:
>> On 17/03/2024 02:34, Kamil Kasperski wrote:
>>> Add dtsi file for T95 tv boxes and add initial
>>> support for T95 5G AXP313A variant with a board name
>>> H616-T95MAX-AXP313A-v3.0
>>>
>>> internal NAND chip is connected to NAND controller
>>> I can't see any nand in sun50i-h616.dtsi, so access to
>>> internal memory is not implemented.
>> Please wrap commit message according to Linux coding style / submission
>> process (neither too early nor over the limit):
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>>
>>> Signed-off-by: Kamil Kasperski <ressetkk@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/allwinner/Makefile | 1 +
>>> arch/arm64/boot/dts/allwinner/sun50i-h616-t95.dtsi | 109 +++++++++++++++++++++
>>> .../dts/allwinner/sun50i-h616-t95max-axp313.dts | 85 ++++++++++++++++
>>> 3 files changed, 195 insertions(+)
>>>
>>> +
>>> + reg_vcc3v3: vcc3v3 {
>>> + /* discrete 3.3V regulator */
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "vcc-3v3";
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + wifi_pwrseq: wifi_pwrseq {
>> No underscores in node names. From where did you copy this code?
>
> arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts#L44
> Seems this one needs a fixup.
>
I see sunxi has a lot of this... I thought we fixed all mainstream
platforms, but apparently not. I'll send a patch.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-03-17 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 1:33 [PATCH v2 0/3] Add initial support for T95 TV boxes Kamil Kasperski
2024-03-17 1:33 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: add t95 string Kamil Kasperski
2024-03-17 14:58 ` Krzysztof Kozlowski
2024-03-17 1:34 ` [PATCH v2 2/3] dt-bindings: arm: sunxi: add T95 AXP313 Kamil Kasperski
2024-03-17 14:58 ` Krzysztof Kozlowski
2024-03-17 1:34 ` [PATCH v2 3/3] arm64: dts: allwinner: h616: add support for T95 tv boxes Kamil Kasperski
2024-03-17 14:57 ` Krzysztof Kozlowski
2024-03-17 15:36 ` Kamil Kasperski
2024-03-17 17:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f369871a-1cd5-4dd8-8b5f-2c6492e72b8b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=ressetkk@gmail.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).