From: Dipen Patel <dipenp@nvidia.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-tegra@vger.kernel.org, timestamp@lists.linux.dev,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de, Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] hte: tegra-194: Convert to platform remove callback returning void
Date: Fri, 12 Apr 2024 10:49:14 -0700 [thread overview]
Message-ID: <0c55102c-f8a2-4f08-ade6-b4026c3314b8@nvidia.com> (raw)
In-Reply-To: <x3cs6kbixp5lro5adn62ljxxrxhmkdymli4xk744hahx6nzdgx@a24jk2hjito7>
On 4/12/24 5:35 AM, Uwe Kleine-König wrote:
> Hello Dipen,
>
> On Mon, Mar 11, 2024 at 09:36:06PM +0100, Uwe Kleine-König wrote:
>> On Mon, Mar 11, 2024 at 10:13:15AM -0700, Dipen Patel wrote:
>>> On 3/11/24 9:04 AM, Thierry Reding wrote:
>>>> On Fri Mar 8, 2024 at 9:51 AM CET, Uwe Kleine-König wrote:
>>>>> The .remove() callback for a platform driver returns an int which makes
>>>>> many driver authors wrongly assume it's possible to do error handling by
>>>>> returning an error code. However the value returned is ignored (apart
>>>>> from emitting a warning) and this typically results in resource leaks.
>>>>>
>>>>> To improve here there is a quest to make the remove callback return
>>>>> void. In the first step of this quest all drivers are converted to
>>>>> .remove_new(), which already returns void. Eventually after all drivers
>>>>> are converted, .remove_new() will be renamed to .remove().
>>>>>
>>>>> Trivially convert this driver from always returning zero in the remove
>>>>> callback to the void returning variant.
>>>>>
>>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>>> ---
>>>>> drivers/hte/hte-tegra194-test.c | 6 ++----
>>>>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>>>
>>>> Acked-by: Thierry Reding <treding@nvidia.com>
>>> Do you want me to take this patch or want to add in your patch series
>>> for the drivers with similar changes?
>>>
>>> Acked-by: Dipen Patel <dipenp@nvidia.com>
>>
>> I don't plan (yet) to care for applying these changes myself. So if you
>> could pick it up that would be great.
>
> Either you didn't pick it up or your tree isn't included in next. Both
> options are not optimal in my eyes.
>
> Given that I want to change struct platform_driver::remove in the merge
> window after v6.10, it would be great if this patch made it into
> v6.10-rc1.
>
> Thanks for considering
> Uwe
>
Sorry for the miss, I will pick it up for 6.10.
Best Regards,
Dipen Patel
prev parent reply other threads:[~2024-04-12 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:51 [PATCH] hte: tegra-194: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-11 16:04 ` Thierry Reding
2024-03-11 17:13 ` Dipen Patel
2024-03-11 20:36 ` Uwe Kleine-König
2024-04-12 12:35 ` Uwe Kleine-König
2024-04-12 17:49 ` Dipen Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c55102c-f8a2-4f08-ade6-b4026c3314b8@nvidia.com \
--to=dipenp@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).