From: Dan Carpenter <dan.carpenter@linaro.org>
To: Marc Dietrich <marvin24@gmx.de>
Cc: linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH V2 4/5] staging: nvec: make i2c controller register writes robust
Date: Mon, 15 Apr 2024 09:07:54 +0300 [thread overview]
Message-ID: <18f8a452-083a-4764-a039-437d305277eb@moroto.mountain> (raw)
In-Reply-To: <20240414150937.22621-1-marvin24@gmx.de>
On Sun, Apr 14, 2024 at 05:09:37PM +0200, Marc Dietrich wrote:
> The i2c controller needs to read back the data written to its registers.
> This way we can avoid the long delay in the interrupt handler.
>
> V2: rebase against staging-next
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This needs to go below the cut off line.
>
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> ---
^^^
Here.
Greg applied all the other patches in the series, so sure, you're
resending 4/5 but probably it's less confusing to just call it [PATCH]
and leave off that it was part of a series... Just put that in the note
under the cut off line.
Send it as a new thread as well.
(I wouldn't have commented on half this stuff except that the v2 comment
was in the wrong place so you're going to need to resend anyway. I
think DRM puts their v2 comments there but no one else does because it's
weird and it doesn't need to be in the permanent git log).
regards,
dan carpenter
next prev parent reply other threads:[~2024-04-15 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 12:31 [PATCH V2 0/4] staging: nvec: improve robustnes during initialization Marc Dietrich
2024-04-06 12:31 ` [PATCH 1/5] staging: nvec: add ability to ignore EC responses in sync writes Marc Dietrich
2024-04-06 12:31 ` [PATCH 2/5] staging: nvec: make keyboard init synchronous Marc Dietrich
2024-04-06 12:31 ` [PATCH 3/5] staging: nvec: make touchpad " Marc Dietrich
2024-04-06 12:31 ` [PATCH 4/5] staging: nvec: make i2c controller register writes robust Marc Dietrich
2024-04-11 12:00 ` Greg KH
2024-04-14 15:09 ` [PATCH V2 " Marc Dietrich
2024-04-15 6:07 ` Dan Carpenter [this message]
2024-04-06 12:31 ` [PATCH 5/5] staging: nvec: update TODO Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18f8a452-083a-4764-a039-437d305277eb@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).