From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Lizhe <sensor1010@163.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"aneesh.kumar@kernel.org" <aneesh.kumar@kernel.org>,
"naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"andersson@kernel.org" <andersson@kernel.org>,
"konrad.dybcio@linaro.org" <konrad.dybcio@linaro.org>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"cristian.marussi@arm.com" <cristian.marussi@arm.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>
Cc: "inuxppc-dev@lists.ozlabs.org" <inuxppc-dev@lists.ozlabs.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: Convert to exit callback returning void
Date: Tue, 9 Apr 2024 15:05:14 +0000 [thread overview]
Message-ID: <7abe982f-54cc-4288-a410-df43cec68f67@csgroup.eu> (raw)
In-Reply-To: <20240409145316.5181-1-sensor1010@163.com>
Le 09/04/2024 à 16:53, Lizhe a écrit :
> For the exit() callback function returning an int type value,
> this leads many driver authors mistakenly believing that error
> handling can be performed by returning an error code. However,
> the returned value is ignored, and to improve this situation,
> it is proposed to modify the return type of the exit() callback
> function to void.
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
> drivers/cpufreq/pasemi-cpufreq.c | 4 +---
> drivers/cpufreq/powernv-cpufreq.c | 4 +---
> drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +--
> drivers/cpufreq/qcom-cpufreq-hw.c | 4 +---
> drivers/cpufreq/qoriq-cpufreq.c | 4 +---
> drivers/cpufreq/scmi-cpufreq.c | 4 +---
> drivers/cpufreq/scpi-cpufreq.c | 4 +---
> drivers/cpufreq/sh-cpufreq.c | 4 +---
> drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +--
> drivers/cpufreq/sparc-us3-cpufreq.c | 3 +--
> drivers/cpufreq/speedstep-centrino.c | 4 +---
> drivers/cpufreq/tegra194-cpufreq.c | 4 +---
> drivers/cpufreq/vexpress-spc-cpufreq.c | 3 +--
> 13 files changed, 13 insertions(+), 35 deletions(-)
Did you do a building test ?
How can this work without changing the definition of exit in struct
cpu_freq driver in include/linux/cpufreq.h ?
Christophe
next prev parent reply other threads:[~2024-04-09 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 14:53 [PATCH] cpufreq: Convert to exit callback returning void Lizhe
2024-04-09 15:05 ` Christophe Leroy [this message]
[not found] ` <6dd5eb5.28532.18ec3682dcf.Coremail.sensor1010@163.com>
2024-04-12 5:51 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7abe982f-54cc-4288-a410-df43cec68f67@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=andersson@kernel.org \
--cc=aneesh.kumar@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=inuxppc-dev@lists.ozlabs.org \
--cc=jonathanh@nvidia.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=rafael@kernel.org \
--cc=sensor1010@163.com \
--cc=sudeep.holla@arm.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).