From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <treding@nvidia.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: tegra20-ac97: convert to dt schema
Date: Tue, 23 Apr 2024 08:49:07 +0200 [thread overview]
Message-ID: <9936177c-1800-4425-be36-bc9f06fcf5ba@kernel.org> (raw)
In-Reply-To: <20240422123830.472109-1-sheharyaar48@gmail.com>
On 22/04/2024 14:38, Mohammad Shehar Yaar Tausif wrote:
> Convert NVIDIA Tegra20 AC97 binding to DT schema.
> Change -gpio to -gpios in both schema and nvidia/tegra20-colibri.dtsi
Why? Please always explain why you are doing things. "gpio" suffix is
deprecated.
>
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
> ---
> Changes v1->v2:
> - change -gpio to -gpios in both schema and dtsi
> - tested against dts
> - add header files and defines
> ---
> .../bindings/sound/nvidia,tegra20-ac97.txt | 36 --------
> .../bindings/sound/nvidia,tegra20-ac97.yaml | 86 +++++++++++++++++++
> arch/arm/boot/dts/nvidia/tegra20-colibri.dtsi | 4 +-
Bindings are separate patches.
> 3 files changed, 88 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.txt
> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.txt
> deleted file mode 100644
> index eaf00102d92c..000000000000
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.txt
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -NVIDIA Tegra 20 AC97 controller
> -
> -Required properties:
> -- compatible : "nvidia,tegra20-ac97"
> -- reg : Should contain AC97 controller registers location and length
> -- interrupts : Should contain AC97 interrupt
> -- resets : Must contain an entry for each entry in reset-names.
> - See ../reset/reset.txt for details.
> -- reset-names : Must include the following entries:
> - - ac97
> -- dmas : Must contain an entry for each entry in clock-names.
> - See ../dma/dma.txt for details.
> -- dma-names : Must include the following entries:
> - - rx
> - - tx
> -- clocks : Must contain one entry, for the module clock.
> - See ../clocks/clock-bindings.txt for details.
> -- nvidia,codec-reset-gpio : The Tegra GPIO controller's phandle and the number
> - of the GPIO used to reset the external AC97 codec
> -- nvidia,codec-sync-gpio : The Tegra GPIO controller's phandle and the number
> - of the GPIO corresponding with the AC97 DAP _FS line
> -
> -Example:
> -
> -ac97@70002000 {
> - compatible = "nvidia,tegra20-ac97";
> - reg = <0x70002000 0x200>;
> - interrupts = <0 81 0x04>;
> - nvidia,codec-reset-gpio = <&gpio 170 0>;
> - nvidia,codec-sync-gpio = <&gpio 120 0>;
> - clocks = <&tegra_car 3>;
> - resets = <&tegra_car 3>;
> - reset-names = "ac97";
> - dmas = <&apbdma 12>, <&apbdma 12>;
> - dma-names = "rx", "tx";
> -};
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.yaml
> new file mode 100644
> index 000000000000..9a68578f6fc3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nvidia,tegra20-ac97.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra20 AC97 controller
> +
> +maintainers:
> + - Thierry Reding <treding@nvidia.com>
> + - Jon Hunter <jonathanh@nvidia.com>
> +
> +properties:
> + compatible:
> + const: nvidia,tegra20-ac97
> +
> + reg:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: ac97
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + dmas:
> + maxItems: 2
> +
> + dma-names:
> + items:
> + - const: rx
> + - const: tx
> +
> + nvidia,codec-reset-gpios:
> + description:
> + The Tegra GPIO controller's phandle and the number
> + of the GPIO used to reset the external AC97 codec
Drop redundant parts and just "Reset pin of external AC97 codec"
> + maxItems: 1
> +
> + nvidia,codec-sync-gpios:
> + description:
> + The Tegra GPIO controller's phandle and the number
> + of the GPIO corresponding with the AC97 DAP _FS line
"AC97 DAP _FS line"
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-23 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 12:38 [PATCH v2] ASoC: dt-bindings: tegra20-ac97: convert to dt schema Mohammad Shehar Yaar Tausif
2024-04-23 6:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9936177c-1800-4425-be36-bc9f06fcf5ba@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sheharyaar48@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).