From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <treding@nvidia.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ASoC: dt-bindings: tegra30-i2s: convert to dt schema
Date: Thu, 25 Apr 2024 17:05:58 +0200 [thread overview]
Message-ID: <99496fb5-50d3-4e91-a519-881cae58b47a@kernel.org> (raw)
In-Reply-To: <20240425090716.176818-1-sheharyaar48@gmail.com>
On 25/04/2024 11:07, Mohammad Shehar Yaar Tausif wrote:
> Convert NVIDIA Tegra30 I2S binding to DT schema and
> add new examples.
>
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
> ---
> Changes v2->v3:
> - Fixed example indentation
> - Fix compatible logic
> - Add new examples from existing dts
Why? One different property does not justify new example. I don't think
I asked for such change.
> - Add clock-names in properties
>
> v2:
> https://lore.kernel.org/all/20240421123037.75680-1-sheharyaar48@gmail.com/
> ---
> .../bindings/sound/nvidia,tegra30-i2s.txt | 27 ------
> .../bindings/sound/nvidia,tegra30-i2s.yaml | 94 +++++++++++++++++++
> 2 files changed, 94 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt
> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt
> deleted file mode 100644
> index 38caa936f6f8..000000000000
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -NVIDIA Tegra30 I2S controller
> -
> -Required properties:
> -- compatible : For Tegra30, must contain "nvidia,tegra30-i2s". For Tegra124,
> - must contain "nvidia,tegra124-i2s". Otherwise, must contain
> - "nvidia,<chip>-i2s" plus at least one of the above, where <chip> is
> - tegra114 or tegra132.
> -- reg : Should contain I2S registers location and length
> -- clocks : Must contain one entry, for the module clock.
> - See ../clocks/clock-bindings.txt for details.
> -- resets : Must contain an entry for each entry in reset-names.
> - See ../reset/reset.txt for details.
> -- reset-names : Must include the following entries:
> - - i2s
> -- nvidia,ahub-cif-ids : The list of AHUB CIF IDs for this port, rx (playback)
> - first, tx (capture) second. See nvidia,tegra30-ahub.txt for values.
> -
> -Example:
> -
> -i2s@70080300 {
> - compatible = "nvidia,tegra30-i2s";
> - reg = <0x70080300 0x100>;
> - nvidia,ahub-cif-ids = <4 4>;
> - clocks = <&tegra_car 11>;
> - resets = <&tegra_car 11>;
> - reset-names = "i2s";
> -};
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml
> new file mode 100644
> index 000000000000..3d8d56c666d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml
> @@ -0,0 +1,94 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nvidia,tegra30-i2s.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra30 I2S controller
> +
> +maintainers:
> + - Thierry Reding <treding@nvidia.com>
> + - Jon Hunter <jonathanh@nvidia.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - nvidia,tegra124-i2s
> + - nvidia,tegra30-i2s
> + - items:
> + - enum:
> + - nvidia,tegra114-i2s
> + - nvidia,tegra132-i2s
> + - enum:
> + - nvidia,tegra124-i2s
> + - nvidia,tegra30-i2s
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + maxItems: 1
This was not in the previous binding and is not explained in commit msg.
Also, this needs to be specific.
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: i2s
> +
> + nvidia,ahub-cif-ids:
> + description: list of AHUB CIF IDs
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + items:
> + - description: rx (playback)
> + - description: tx (capture)
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - resets
> + - reset-names
> + - nvidia,ahub-cif-ids
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/tegra30-car.h>
> +
> + i2s@70080300 {
> + compatible = "nvidia,tegra30-i2s";
> + reg = <0x70080300 0x100>;
> + nvidia,ahub-cif-ids = <4 4>;
> + clocks = <&tegra_car TEGRA30_CLK_I2S0>;
> + resets = <&tegra_car 30>;
> + reset-names = "i2s";
> + };
Just keep one or two examples.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-25 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:07 [PATCH v3] ASoC: dt-bindings: tegra30-i2s: convert to dt schema Mohammad Shehar Yaar Tausif
2024-04-25 15:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99496fb5-50d3-4e91-a519-881cae58b47a@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sheharyaar48@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).