From: Allen <allen.lkml@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Allen Pais <apais@linux.microsoft.com>,
linux-kernel@vger.kernel.org, tj@kernel.org,
keescook@chromium.org, vkoul@kernel.org, marcan@marcan.st,
sven@svenpeter.dev, florian.fainelli@broadcom.com,
rjui@broadcom.com, sbranden@broadcom.com, paul@crapouillou.net,
Eugeniy.Paltsev@synopsys.com, manivannan.sadhasivam@linaro.org,
vireshk@kernel.org, Frank.Li@nxp.com, leoyang.li@nxp.com,
zw@zh-kernel.org, wangzhou1@hisilicon.com, haijie1@huawei.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
sean.wang@mediatek.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, afaerber@suse.de,
logang@deltatee.com, daniel@zonque.org,
haojian.zhuang@gmail.com, robert.jarzmik@free.fr,
andersson@kernel.org, konrad.dybcio@linaro.org,
orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
zhang.lyra@gmail.com, patrice.chotard@foss.st.com,
linus.walleij@linaro.org, wens@csie.org,
jernej.skrabec@gmail.com, peter.ujfalusi@gmail.com,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, jassisinghbrar@gmail.com,
mchehab@kernel.org, maintainers@bluecherrydvr.com,
aubin.constans@microchip.com, ulf.hansson@linaro.org,
manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl,
jh80.chung@samsung.com, oakad@yahoo.com,
hayashi.kunihiko@socionext.com, mhiramat@kernel.org,
brucechang@via.com.tw, HaraldWelte@viatech.com,
pierre@ossman.eu, duncan.sands@free.fr, oneukum@suse.com,
openipmi-developer@lists.sourceforge.net,
dmaengine@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, imx@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org,
linux-mediatek@lists.infradead.org,
linux-actions@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-media@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 4/9] USB: Convert from tasklet to BH workqueue
Date: Thu, 28 Mar 2024 10:54:07 -0700 [thread overview]
Message-ID: <CAOMdWS+4T7rw577q9iW_oin8bbVF4m6Mpx-L2riqno5QX_L=WQ@mail.gmail.com> (raw)
In-Reply-To: <42c445b4-a156-4c43-bf98-bd2a9ac7a4fa@rowland.harvard.edu>
> >
> > This patch converts drivers/infiniband/* from tasklet to BH workqueue.
> >
> > Based on the work done by Tejun Heo <tj@kernel.org>
> > Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
> >
> > Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> > ---
>
> > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> > index c0e005670d67..88d8e1c366cd 100644
> > --- a/drivers/usb/core/hcd.c
> > +++ b/drivers/usb/core/hcd.c
>
> > @@ -1662,10 +1663,9 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
> > usb_put_urb(urb);
> > }
> >
> > -static void usb_giveback_urb_bh(struct work_struct *work)
> > +static void usb_giveback_urb_bh(struct work_struct *t)
> > {
> > - struct giveback_urb_bh *bh =
> > - container_of(work, struct giveback_urb_bh, bh);
> > + struct giveback_urb_bh *bh = from_work(bh, t, bh);
> > struct list_head local_list;
> >
> > spin_lock_irq(&bh->lock);
>
> Is there any reason for this apparently pointless change of a local
> variable's name?
No, it was done just to keep things consistent across the kernel.
I can revert it back to *work if you'd prefer.
Thanks.
>
> Alan Stern
>
--
- Allen
next prev parent reply other threads:[~2024-03-28 17:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:03 [PATCH 0/9] Convert Tasklets to BH Workqueues Allen Pais
2024-03-27 16:03 ` [PATCH 1/9] hyperv: Convert from tasklet to BH workqueue Allen Pais
2024-04-03 16:43 ` Allen
2024-03-27 16:03 ` [PATCH 2/9] dma: " Allen Pais
2024-03-28 5:55 ` Vinod Koul
2024-03-28 10:08 ` Arnd Bergmann
2024-03-28 18:31 ` Vinod Koul
2024-03-28 19:39 ` Allen
2024-03-28 19:49 ` Arnd Bergmann
2024-03-28 20:01 ` Allen
2024-03-29 16:38 ` Vinod Koul
2024-03-29 16:39 ` Vinod Koul
2024-03-28 17:49 ` Allen
2024-04-02 12:25 ` Linus Walleij
2024-04-02 13:11 ` Vinod Koul
2024-03-27 16:03 ` [PATCH 3/9] IB: " Allen Pais
2024-04-07 18:56 ` Zhu Yanjun
2024-03-27 16:03 ` [PATCH 4/9] USB: " Allen Pais
2024-03-27 16:20 ` Duncan Sands
2024-03-27 16:55 ` Greg KH
2024-03-27 16:58 ` Allen
2024-03-27 17:55 ` Alan Stern
2024-03-28 17:54 ` Allen [this message]
2024-03-27 16:03 ` [PATCH 5/9] mailbox: " Allen Pais
2024-03-27 16:03 ` [PATCH 6/9] ipmi: " Allen Pais
2024-03-27 17:58 ` Corey Minyard
2024-03-28 17:52 ` Allen
2024-03-28 19:23 ` Corey Minyard
2024-03-28 19:41 ` Allen
2024-03-28 19:52 ` Corey Minyard
2024-03-28 19:58 ` Allen
2024-03-27 16:03 ` [PATCH 7/9] s390: " Allen Pais
2024-04-02 12:48 ` Alexandra Winter
2024-04-03 13:33 ` Allen
2024-04-08 9:33 ` Heiko Carstens
2024-04-08 10:03 ` Harald Freudenberger
2024-03-27 16:03 ` [PATCH 8/9] drivers/media/*: " Allen Pais
2024-04-24 9:12 ` Hans Verkuil
2024-04-24 16:48 ` Allen Pais
2024-03-27 16:03 ` [PATCH 9/9] mmc: " Allen Pais
2024-03-27 19:35 ` Jernej Škrabec
2024-03-28 10:16 ` Christian Loehle
2024-03-28 17:47 ` Allen
2024-03-28 12:53 ` Ulf Hansson
2024-03-28 13:37 ` Linus Walleij
2024-03-28 16:21 ` Tejun Heo
2024-04-02 10:15 ` Ulf Hansson
2024-04-05 9:28 ` Michał Mirosław
2024-06-03 12:38 ` Aubin Constans
2024-06-03 17:25 ` Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMdWS+4T7rw577q9iW_oin8bbVF4m6Mpx-L2riqno5QX_L=WQ@mail.gmail.com' \
--to=allen.lkml@gmail.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Frank.Li@nxp.com \
--cc=HaraldWelte@viatech.com \
--cc=afaerber@suse.de \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=apais@linux.microsoft.com \
--cc=asahi@lists.linux.dev \
--cc=aubin.constans@microchip.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brucechang@via.com.tw \
--cc=daniel@zonque.org \
--cc=decui@microsoft.com \
--cc=dmaengine@vger.kernel.org \
--cc=duncan.sands@free.fr \
--cc=florian.fainelli@broadcom.com \
--cc=haijie1@huawei.com \
--cc=haiyangz@microsoft.com \
--cc=haojian.zhuang@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=imx@lists.linux.dev \
--cc=jassisinghbrar@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=kys@microsoft.com \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=maintainers@bluecherrydvr.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=manuel.lauss@gmail.com \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=oneukum@suse.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=orsonzhai@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul@crapouillou.net \
--cc=peter.ujfalusi@gmail.com \
--cc=pierre@ossman.eu \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=sean.wang@mediatek.com \
--cc=shawnguo@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=sven@svenpeter.dev \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=wei.liu@kernel.org \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).