From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Mikko Perttunen" <cyndis@kapsi.fi>
Cc: "Mikko Perttunen" <mperttunen@nvidia.com>,
<dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186
Date: Thu, 22 Feb 2024 19:06:11 +0100 [thread overview]
Message-ID: <CZBT2NJ7IDA5.1OXUZ5JBIQE5C@gmail.com> (raw)
In-Reply-To: <20240222010517.1573931-1-cyndis@kapsi.fi>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Thu Feb 22, 2024 at 2:05 AM CET, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@nvidia.com>
>
> On Tegra186, secure world applications may need to access host1x
> during suspend/resume, and rely on the kernel to keep Host1x out
> of reset during the suspend cycle. As such, as a quirk,
> skip asserting Host1x's reset on Tegra186.
>
> We don't need to keep the clocks enabled, as BPMP ensures the clock
> stays on while Host1x is being used. On newer SoC's, the reset line
> is inaccessible, so there is no need for the quirk.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/gpu/host1x/dev.c | 15 +++++++++------
> drivers/gpu/host1x/dev.h | 6 ++++++
> 2 files changed, 15 insertions(+), 6 deletions(-)
Applied to drm-misc-fixes, though I added the Fixes: tag that Jon
mentioned in reply to v1 of this as well as his Reviewed-by and
Tested-by as well, since this is pretty much the same patch except
for the comments.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-22 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 1:05 [PATCH] gpu: host1x: Skip reset assert on Tegra186 Mikko Perttunen
2024-02-22 18:06 ` Thierry Reding [this message]
2024-02-24 6:02 ` Mikko Perttunen
-- strict thread matches above, loose matches on Subject: below --
2024-02-14 11:40 Mikko Perttunen
2024-02-15 11:07 ` Jon Hunter
2024-02-16 10:02 ` Thierry Reding
2024-02-19 2:18 ` Mikko Perttunen
2024-02-19 16:31 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZBT2NJ7IDA5.1OXUZ5JBIQE5C@gmail.com \
--to=thierry.reding@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).